-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript errors #473
Comments
@christophby whats the best way to get around this temporarily? |
@1kDustin I'm using patch-package to put a |
First time trying out gifted charts. Are these errors new in the latest version, or have they always been there? Is it worse using an older version? Since I'm not yet invested in this particular package, it just look nice for what I want, I don't really want to do some hacks of adding 'nocheck' to a bunch of files. Any chance this will be fixed soon? |
Hi @digitalthjarta |
Thank you! |
Nice @Abhinandan-Kushwaha |
One temporary fix, that is not ideal, is to add the noimplicitAny option to your tsconfig:
To enforce some of the rules enforced by that config option, you can utilize this typscript-eslint rule. Note that their docs say to prefer |
what is the best way to workaround this? |
Any updates here? We can not get a build with tsc build |
This repo exports direct typescript code without bundling it, all typescript errors from this package (and Regardless of a user's tsconfig settings, these errors prevent teams from building or checking types on their own code. This can be fixed if decide to either:
|
Any updates to this? Painful to see all github actions fail because of the missing types from this package. |
Sorry @tfsjohan @dogancancelik12 for the delay. The web counterpart of this library is almost ready. So I wanted to add types in such a way that it satisfies both- react-native and reactJS. Check my new repo- https://github.com/Abhinandan-Kushwaha/react-gifted-charts Expect this all to be ready by this weekend. |
Here's a workaround for this issue: https://gist.github.com/araphiel/b3d13ade7f9fe69e99c3d053196557d2 Hope this can help 👋 |
Any updates on this @Abhinandan-Kushwaha ? :) |
It seems expo eas build failed because of this type error. // Saying this because |
Windows 10 - I got some troubles running command to update every file from this guide, so I used this command in my cmd in order to add
cd ./node_modules/react-native-gifted-charts/src
for /R %i in (*.ts *.tsx) do (echo // @ts-nocheck > temp & type %i >> temp & move /Y temp %i)
npx patch-package react-native-gifted-charts |
Any updates on this ? |
Hi @christophby @1kDustin @digitalthjarta @jasonleibowitz @bryanltobing @dogancancelik12 @araphiel @tfsjohan @cjmling @rodnoycry @kuldip-simform 👋
|
Describe the bug
If you run
yarn tsc
you'll get 187 typescript errors in this project.Most of them are
Parameter 'xyz' implicitly has an 'any' type.
To Reproduce
Steps to reproduce the behavior:
tsconfig.json
in the root with{"extends": "@tsconfig/react-native/tsconfig.json"}
@tsconfig/react-native
to the dev dependencies (is a default in react native typescript projects)yarn tsc
ornpm run tsc
Expected behavior
There shouldn't be any errors.
The text was updated successfully, but these errors were encountered: