Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abris #329 use pull_request_target to fix PRs from forks #334

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

cerveada
Copy link
Collaborator

As I understand it, GitHub considers any fork PR as potentially dangerous. So when using on pull-request in action, it will always set all permissions to read.

There is pull_request_target that is less safe, but it should allow write permission.

So I am switching the action to pull_request_target and to mitigate the unsafeness I will also switch settings to Require approval for all outside collaborators.

There are other solutions to this that may be better, but also more complicated, if you want to look into it @miroslavpojer @Zejnilovic

For more info, see:

@cerveada cerveada merged commit 9b32045 into master Jul 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants