Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release notes entry enforcement #211

Closed
benedeki opened this issue Jun 13, 2024 · 0 comments · Fixed by #212
Closed

Release notes entry enforcement #211

benedeki opened this issue Jun 13, 2024 · 0 comments · Fixed by #212
Assignees
@benedeki
Labels
documentation Improvements or additions to documentation enhancement New feature or request infrastructure Project setup and deployment

Comments

@benedeki
Copy link
Contributor

Background

With the ability to generate release notes draft, it is advisable to have release notes on issues.

Feature

Use GitHub workflow actions that would enforce to have a release note comment on a PR, and upon merging would copy it to the relevant issue, where it can be picked up for release notes generate.

Unless the PR is marked as not needing Release notes.

The tag to ignore release notes presence is 'no RN'.
@benedeki benedeki added documentation Improvements or additions to documentation enhancement New feature or request infrastructure Project setup and deployment labels Jun 13, 2024
@benedeki benedeki self-assigned this Jun 13, 2024
benedeki added a commit that referenced this issue Jun 13, 2024
@benedeki
#211: Release notes entry enforcement
e77987e 
* changed the label to skip issue for release notes from default to `no RN`
* added action to verify a PR has Release note comment, unless marked with `no RN` label
* added action to copy Release note comment from PR to linked issues upon merge to master
@benedeki benedeki mentioned this issue Jun 13, 2024
Merged
benedeki added a commit that referenced this issue Jun 24, 2024
@benedeki @lsulak
@Zejnilovic @miroslavpojer
#211: Release notes entry enforcement (#212)
f5ac426 
* changed the label to skip issue for release notes from default to `no RN`
* added action to verify a PR has Release note comment, unless marked with `no RN` label
* added action to copy Release note comment from PR to linked issues upon merge to master
* added test filenames check action

---------

Co-authored-by: Ladislav Sulak <laco.sulak@gmail.com>
Co-authored-by: Saša Zejnilović <zejnils@gmail.com>
Co-authored-by: miroslavpojer <miroslav.pojer@absa.africa>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benedeki benedeki

Labels
documentation Improvements or additions to documentation enhancement New feature or request infrastructure Project setup and deployment
Projects
CPS small repos project
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#211: Release notes entry enforcement AbsaOSS/atum-service
1 participant
@benedeki