Add support for SSR/SSG #12
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So basically isValidCSSColor is a fundamental library function, we need to reimplement it using color-name to check css named colors and regular expressions for verifying other formats. |
|
I think it should be enough to just not use global document object and use Document from DI instead |
This will also work, but we need to pass it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once fix for angular/angular-cli#27590 is published (should be the next patch version as the fix PR is already merged) we will need to update
@angular/angular-clipackage.Note that
CpsDividerwas removed as it does not support SSR (it is accessingdocumentdirectly -_dividerColor->getCSSColor->isValidCSSColor->document.createElementon colors-utils.ts:13)