Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Document DI Token #380

Closed
fateeand opened this issue May 7, 2024 · 0 comments · Fixed by #381
Closed

Use Document DI Token #380

fateeand opened this issue May 7, 2024 · 0 comments · Fixed by #381
Assignees
@fateeand
Labels
enhancement New feature or request library

Comments

@fateeand
Copy link
Collaborator

fateeand commented May 7, 2024

In order to make the library more SSG/SSR compatible we need to use Document from DI instead of a global document object.

Need to reimplement isValidCSSColor function as well
AbsaOSS/cps-mdoc-viewer#12
@fateeand fateeand added enhancement New feature or request library labels May 7, 2024
@fateeand fateeand self-assigned this May 7, 2024
@fateeand fateeand linked a pull request May 7, 2024 that will close this issue
#380 Use document DI token #381
Merged
fateeand added a commit that referenced this issue May 9, 2024
@fateeand
#380 Use document DI token (#381)
528d198 
* substitute document and window objects

* pass document to colors utils

* fix warnings

* more to prev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fateeand fateeand

Labels
enhancement New feature or request library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#380 Use document DI token AbsaOSS/cps-shared-ui
1 participant
@fateeand