Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple date formats in Helper scripts #1835

Closed
benedeki opened this issue Jun 30, 2021 · 1 comment · Fixed by #1837
Closed

Support multiple date formats in Helper scripts #1835

benedeki opened this issue Jun 30, 2021 · 1 comment · Fixed by #1837
Assignees
@benedeki
Labels
feature New feature priority: low Nice to have run scripts Helper run scripts are affected

Comments

@benedeki
Copy link
Collaborator

Background

In Helper scripts date is parsed for a log file naming.

Feature

On Windows the date OS function result is locale dependent. Make the Helper scripts easy to configure for different date formats
@benedeki benedeki added feature New feature priority: low Nice to have run scripts Helper run scripts are affected labels Jun 30, 2021
@benedeki benedeki self-assigned this Jun 30, 2021
benedeki added a commit that referenced this issue Jun 30, 2021
@benedeki
#1835: Support multiple date formats in Helper scripts
1987301 
* added configuration for date parsing type
* .gitattributes changed to hopefully better handle CRLF in native Windows files
* LF -> CRLF in *.cmd and *.bat files
@dk1844 dk1844 linked a pull request Jun 30, 2021 that will close this issue
#1835: Support multiple date formats in Helper scripts #1837
Merged
benedeki added a commit that referenced this issue Jul 13, 2021
@benedeki
#1835: Support multiple date formats in Helper scripts
31cbffd 
* automatic universal date & time parsing regardless of locale in Windows helper scripts
* CRLF for *.cmd and *.bat files in editor
@benedeki
Copy link
Collaborator Author

Release notes:
Windows Helper scripts are now parse the date independently of locale (for the log file name purpose).

benedeki added a commit that referenced this issue Jul 31, 2021
@benedeki
#1835: Support multiple date formats in Helper scripts (#1837)
81f75c3 
#1835: Support multiple date formats in Helper scripts
* automatic universal date & time parsing regardless of locale in Windows helper scripts
* LF -> CRLF in *.cmd and *.bat files
* CRLF for *.cmd and *.bat files in editor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benedeki benedeki

Labels
feature New feature priority: low Nice to have run scripts Helper run scripts are affected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1835: Support multiple date formats in Helper scripts AbsaOSS/enceladus
1 participant
@benedeki