Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the ability to set a datset filter via the configuration file #1867

Closed
benedeki opened this issue Jul 26, 2021 · 1 comment · Fixed by #1980
Closed

Remove the ability to set a datset filter via the configuration file #1867

benedeki opened this issue Jul 26, 2021 · 1 comment · Fixed by #1980
Assignees
@dk1844
Labels
Conformance Conformance Job affected feature New feature good first issue Good for newcomers priority: low Nice to have Streaming Conformance on streaming data sources

Comments

@benedeki
Copy link
Collaborator

Background

When the UI will have been done, the ability to set the dataset filter via the configuration the more disruptive and confusing rather than helping.

Feature

Remove the ability to set the dataset filter via the configuration file.

Proposed Solution

Solution Ideas

  1. See the class FilterFromConfig and its usage.
@benedeki benedeki added feature New feature Conformance Conformance Job affected priority: low Nice to have Streaming Conformance on streaming data sources good first issue Good for newcomers labels Jul 26, 2021
@dk1844 dk1844 self-assigned this Nov 4, 2021
dk1844 added a commit that referenced this issue Nov 11, 2021
@dk1844
#1867 filter from config removed, including tests.
5f75976
@dk1844 dk1844 mentioned this issue Nov 11, 2021
Merged
dk1844 added a commit that referenced this issue Nov 19, 2021
@dk1844
#1867 filter from config removed, including tests. (#1980)
fbb1adf
@dk1844
Copy link
Contributor

dk1844 commented Nov 19, 2021

Release notes
Enceladus no longer support loading filter from config (config tree dataframefilter.$dataFrameName).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dk1844 dk1844

Labels
Conformance Conformance Job affected feature New feature good first issue Good for newcomers priority: low Nice to have Streaming Conformance on streaming data sources
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1867 filter from config removed, including tests. AbsaOSS/enceladus
2 participants
@dk1844 @benedeki