Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons mixup #1978

Closed
dk1844 opened this issue Nov 11, 2021 · 1 comment · Fixed by #1979
Closed

Icons mixup #1978

dk1844 opened this issue Nov 11, 2021 · 1 comment · Fixed by #1979
Labels
bug Something isn't working priority: undecided Undecided priority to be assigned after discussion

Comments

@dk1844
Copy link
Contributor

dk1844 commented Nov 11, 2021

Describe the bug

As @kevinwallimann discovered, the filter icons seem a bit mixed up for NOT, Equals and Differs.

To Reproduce

Steps to reproduce:

  1. Open dialog to create a mapping table
  2. Filter > Add

Expected behavior

The Equals icon should be used for Differs, perhaps switch NOT and Differs, too.

Screenshots

icons-mixup
@dk1844 dk1844 added bug Something isn't working priority: undecided Undecided priority to be assigned after discussion labels Nov 11, 2021
dk1844 added a commit that referenced this issue Nov 11, 2021
@dk1844
#1978 icons mixup corrected for filter edit
640600c
@dk1844 dk1844 mentioned this issue Nov 11, 2021
Merged
@dk1844
Copy link
Contributor Author

dk1844 commented Nov 11, 2021

Release notes
Filter edit icons are now switched to better convey their expected meaning and to conform to the icons used in the filter view.

dk1844 added a commit that referenced this issue Nov 11, 2021
@dk1844
#1978 icons mixup corrected for filter edit (#1979)
ae73df8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority: undecided Undecided priority to be assigned after discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1978 icons mixup corrected for filter edit AbsaOSS/enceladus
1 participant
@dk1844