Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make built in ErrorSender plugin use kafka security params #2028

Closed
Zejnilovic opened this issue Mar 11, 2022 · 1 comment · Fixed by #2029
Closed

Make built in ErrorSender plugin use kafka security params #2028

Zejnilovic opened this issue Mar 11, 2022 · 1 comment · Fixed by #2029
Labels
bug Something isn't working priority: undecided Undecided priority to be assigned after discussion

Comments

@Zejnilovic
Copy link
Contributor

Zejnilovic commented Mar 11, 2022 •
edited

Describe the bug

Currently, only the info sender plugin leverages the Kafka security params

Expected behavior

Error Sender plugin also uses kafka security params
@Zejnilovic Zejnilovic added bug Something isn't working priority: undecided Undecided priority to be assigned after discussion labels Mar 11, 2022
dk1844 added a commit that referenced this issue Mar 11, 2022
@dk1844
#2028 bugfix: kafka error sender now support schema registry security…
77f9bcd 
… params
dk1844 added a commit that referenced this issue Mar 11, 2022
@dk1844
#2028 bugfix: kafka error sender now support schema registry security…
267bace 
… params - test case extended
@dk1844 dk1844 linked a pull request Mar 11, 2022 that will close this issue
#2028 bugfix: kafka error sender now support schema registry security params #2029
Merged
dk1844 added a commit that referenced this issue Mar 11, 2022
@dk1844
#2028 bugfix: kafka error sender now support schema registry security…
1f6d978 
… params - via registry config
dk1844 added a commit that referenced this issue Mar 11, 2022
@dk1844
#2028 cleanup
700afff
dk1844 added a commit that referenced this issue Mar 17, 2022
@dk1844
#2028 trustStore/keyStore params passing to kafka producers - passed …
3a74c11 
…via spark.executorEnv (+unit test) - todo test this
dk1844 added a commit that referenced this issue Mar 17, 2022
@dk1844
#2028 trustStore/keyStore params passing to kafka producers - passed …
cfa2a25 
…via spark.executor.extraJavaOptions (+unit test) - todo test this
dk1844 added a commit that referenced this issue Mar 18, 2022
@dk1844
#2028 SecureConfig methods redone + unit test
50f892b
dk1844 added a commit that referenced this issue Mar 18, 2022
@dk1844
#2028 license check fix
ad316f6
dk1844 added a commit that referenced this issue Mar 22, 2022
@dk1844
#2028 PR review: Moved `CommonJobExecution.javaOptsStringFromConfigMa…
b7c804d 
…p` to `SecureConfig.javaOptsStringFromConfigMap` (unit tests adjusted)
dk1844 added a commit that referenced this issue Mar 22, 2022
@dk1844
#2028 bugfix: kafka error sender now support schema registry security…
6f26151 
… params (#2029)

* #2028 bugfix: kafka error sender now support schema registry security params
* #2028 trustStore/keyStore params passing to kafka producers - passed via spark.executor.extraJavaOptions (+unit test) - 
* #2028 SecureConfig methods redone + unit test
* #2028 license check fix
* #2028 PR review: Moved `CommonJobExecution.javaOptsStringFromConfigMap` to `SecureConfig.javaOptsStringFromConfigMap` (unit tests adjusted)
@dk1844 dk1844 mentioned this issue Mar 22, 2022
Merged
@dk1844
Copy link
Contributor

dk1844 commented Mar 22, 2022

Release notes:
Secure Kafka (SASL_SSL) and Secure Schema Registry (Basic Auth) registry is now correctly usable with error-topic-sending.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority: undecided Undecided priority to be assigned after discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2028 bugfix: kafka error sender now support schema registry security params AbsaOSS/enceladus
2 participants
@dk1844 @Zejnilovic