Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated spark-jobs configuration referncing Menas #2105

Closed
benedeki opened this issue Aug 4, 2022 · 1 comment
Closed

Outdated spark-jobs configuration referncing Menas #2105

benedeki opened this issue Aug 4, 2022 · 1 comment
Assignees
@jakipatryk
Labels
bug Something isn't working Conformance Conformance Job affected good first issue Good for newcomers priority: high Critical to the health of the project refactoring Improving code quality, paying off tech debt, aligning API, cleanup of unused code Rest-API Rest-API component affected Standardization Standardization Job affected

Comments

@benedeki
Copy link
Collaborator

benedeki commented Aug 4, 2022 •
edited

Describe the bug

Outdated spark-jobs configuration referencing Menas

To Reproduce

Check he reference.conf in Spark-jobs module

Expected behavior

Configuration should not use Menas in the configuration keys.
Fix the default reference.conf not to use misleading values with Menas

Suggested fixes

  • Change the keys starting with menas.rest. to enceladus.rest.
  • Change the demo values to user rest-api rather then menas
  • Fix the examples configurations
  • Fix the documentation (both README.md and github.io ones)
@benedeki benedeki added bug Something isn't working Conformance Conformance Job affected good first issue Good for newcomers priority: high Critical to the health of the project Rest-API Rest-API component affected Standardization Standardization Job affected refactoring Improving code quality, paying off tech debt, aligning API, cleanup of unused code labels Aug 4, 2022
jakipatryk added a commit that referenced this issue Aug 8, 2022
@jakipatryk
#2105 Change conf keys prefix from menas.rest to enceladus.rest
711c3b0
jakipatryk added a commit that referenced this issue Aug 8, 2022
@jakipatryk
#2105 Change to enceladus.rest confs where old prefix was used
239606a
jakipatryk added a commit that referenced this issue Aug 8, 2022
@jakipatryk
#2105 Update README to use enceladus.rest prefix instead old one
b166300
@jakipatryk jakipatryk mentioned this issue Aug 8, 2022
Merged
jakipatryk added a commit that referenced this issue Aug 8, 2022
@jakipatryk
#2105 Change menas.rest to enceladus.rest in docs
3e2a974
@jakipatryk jakipatryk mentioned this issue Aug 8, 2022
Merged
jakipatryk added a commit that referenced this issue Aug 9, 2022
@jakipatryk
#2105 Set more sensible config defaults for enceladus.rest.uri
dcbfc65
jakipatryk added a commit that referenced this issue Aug 26, 2022
@jakipatryk
#2105 Change menas.rest to enceladus.rest in Github Pages (#2108)
b6bfc9d
jakipatryk added a commit that referenced this issue Aug 26, 2022
@jakipatryk
#2105 Change spark-jobs config keys prefix from menas.rest to `ence…
10bdff8 
…ladus.rest` (#2107)
@jakipatryk
Copy link
Collaborator

jakipatryk commented Sep 1, 2022 •
edited

Release notes
spark-jobs: Configuration keys starting with menas.rest have been changed to enceladus.rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakipatryk jakipatryk

Labels
bug Something isn't working Conformance Conformance Job affected good first issue Good for newcomers priority: high Critical to the health of the project refactoring Improving code quality, paying off tech debt, aligning API, cleanup of unused code Rest-API Rest-API component affected Standardization Standardization Job affected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benedeki @jakipatryk