Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples README point to wrong path for example _INFO files #2109

Closed
jakipatryk opened this issue Aug 10, 2022 · 0 comments · Fixed by #2110
Closed

examples README point to wrong path for example _INFO files #2109

jakipatryk opened this issue Aug 10, 2022 · 0 comments · Fixed by #2110
Assignees
@jakipatryk
Labels
bug Something isn't working docs Documentation

Comments

@jakipatryk
Copy link
Collaborator

Describe the bug

Links to example _INFO files in README of examples module are broken (point to a page that doesn't exist, 404).

To Reproduce

  1. Navigate to examples README.
  2. Click on links "Template for bare minimum required data" and "Template of recommended _INFO file content".

Expected behavior

Links should point to https://github.com/AbsaOSS/enceladus/blob/[[branch]]/examples/info_files/_INFO_file_template_minimal.json and https://github.com/AbsaOSS/enceladus/blob/[[branch]]/examples/info_files/_INFO_file_template_recommended.json respectively.
@jakipatryk jakipatryk added bug Something isn't working docs Documentation labels Aug 10, 2022
@jakipatryk jakipatryk self-assigned this Aug 10, 2022
jakipatryk added a commit that referenced this issue Aug 10, 2022
@jakipatryk
#2109 Fix path to example _INFO files
2185717
@jakipatryk jakipatryk mentioned this issue Aug 10, 2022
Merged
jakipatryk added a commit that referenced this issue Aug 11, 2022
@jakipatryk
#2109 Fix path to example _INFO files (#2110)
b20e0f8 
* changed relative path for links to _INFO files in README of examples module from "examples/info_files/..." to "info_files/...".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakipatryk jakipatryk

Labels
bug Something isn't working docs Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2109 Fix path to example _INFO files AbsaOSS/enceladus
1 participant
@jakipatryk