Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename entities in code that mention Menas but REST API is meant #2111

Closed
jakipatryk opened this issue Aug 10, 2022 · 1 comment · Fixed by #2114
Closed

Rename entities in code that mention Menas but REST API is meant #2111

jakipatryk opened this issue Aug 10, 2022 · 1 comment · Fixed by #2114
Assignees
@jakipatryk
Labels
refactoring Improving code quality, paying off tech debt, aligning API, cleanup of unused code

Comments

@jakipatryk
Copy link
Collaborator

Menas was API+UI, but now is just UI. However, there are still plenty of variables/classes/etc. with menas in the name that should be somehow renamed, for example:

  • CommonJobExecution has vals: menasBaseUrls, menasUrlsRetryCount, menasSetup
  • MenasConnectionStringParser
  • menas-credentials.conf (and other keytab/credentials related things)
  • MenasDAO (?)
  • data-model/menas (?)

Note

While some of them are pretty obvious renames (like menasBaseUrls to restApiBaseUrls, or menas-credentials.conf to rest_api-credentials.conf), a few are non-obvious and probably need a bit of discussion (like MenasDAO, whether rename it at all, and if so into what).
@jakipatryk jakipatryk added the refactoring Improving code quality, paying off tech debt, aligning API, cleanup of unused code label Aug 10, 2022
jakipatryk added a commit that referenced this issue Aug 11, 2022
@jakipatryk
#2111 Rename Menas (credentials, ConnectionStringParser, vals) to RES…
3a47196 
…T API
jakipatryk added a commit that referenced this issue Aug 12, 2022
@jakipatryk
#2111 Change rest-api confs with menas prefix
e42d456
jakipatryk added a commit that referenced this issue Aug 12, 2022
@jakipatryk
#2111 Use ENCELADUS_REST_... envs in rest-api Dockerfile
12e0318
jakipatryk added a commit that referenced this issue Aug 15, 2022
@jakipatryk
#2111 Rename MenasDAO to EnceladusDAO
e6864d8
jakipatryk added a commit that referenced this issue Aug 15, 2022
@jakipatryk
#2111 Rename MenasDAO to EnceladusDAO
31cc593
jakipatryk added a commit that referenced this issue Aug 15, 2022
@jakipatryk
#2111 Rename MenasPlugin to EnceladusAtumPlugin
a665067
jakipatryk added a commit that referenced this issue Aug 15, 2022
@jakipatryk
#2111 Fix name of credentials file in README
1df097b
jakipatryk added a commit that referenced this issue Aug 15, 2022
@jakipatryk
#2111 Rename menasRestURI to enceladusRestURI in Oozie config
7d62f51
jakipatryk added a commit that referenced this issue Aug 16, 2022
@jakipatryk
#2111 Make credentials CLI options backward compatible
b09fee1
jakipatryk added a commit that referenced this issue Aug 16, 2022
@jakipatryk
#2111 Rename rest-api auth trait and classes
4f1328f
jakipatryk added a commit that referenced this issue Aug 16, 2022
@jakipatryk
#2111 Align test class name with source class name
47c0790
jakipatryk added a commit that referenced this issue Aug 16, 2022
@jakipatryk
#2111 Change last docs mentioning Menas instead of Enceladus/REST
c79d50b
jakipatryk added a commit that referenced this issue Aug 16, 2022
@jakipatryk
#2111 Fix enceladus.rest.uri in test_jsons
57d922c
jakipatryk added a commit that referenced this issue Aug 16, 2022
@jakipatryk
#2111 Remove irrelevant part of comments
7fbcd45
jakipatryk added a commit that referenced this issue Aug 16, 2022
@jakipatryk
#2111 Use /rest_api uri instead of /menas in AuthClientSuite
efb969b
jakipatryk added a commit that referenced this issue Aug 16, 2022
@jakipatryk
#2111 Fix comments referencing Menas
6f7524c
jakipatryk added a commit that referenced this issue Aug 16, 2022
@jakipatryk
#2111 Rename SparkMenasSchemaConvertor to `SparkEnceladusSchemaConv…
b9b1e50 
…ertor`
jakipatryk added a commit that referenced this issue Aug 16, 2022
@jakipatryk
#2111 Rename val menasBaseUrls to restApiBaseUrls in StreamingFix…
f9e979a 
…ture
jakipatryk added a commit that referenced this issue Aug 16, 2022
@jakipatryk
#2111 Adjust test names in RestDaoFactorySuite
f508b44
jakipatryk added a commit that referenced this issue Aug 16, 2022
@jakipatryk
#2111 Rename MenasKerberos... classes
08f212d
jakipatryk added a commit that referenced this issue Aug 16, 2022
@jakipatryk
#2111 Fix misleading log messages
40f8019
@jakipatryk jakipatryk mentioned this issue Aug 17, 2022
Merged
jakipatryk added a commit that referenced this issue Aug 17, 2022
@jakipatryk
#2111 Rename val describing env in ConfigurationController
2540fc7
jakipatryk added a commit that referenced this issue Aug 17, 2022
@jakipatryk
#2111 Change Menas API to Encelcadus API in SpringFoxConfig
aa7f8dc
jakipatryk added a commit that referenced this issue Aug 17, 2022
@jakipatryk
#2111 Change Menas to Encelcadus in SchemaType
9189f8a
jakipatryk added a commit that referenced this issue Aug 17, 2022
@jakipatryk
#2111 Rename model.menas package to model.backend
043c525
jakipatryk added a commit that referenced this issue Aug 17, 2022
@jakipatryk
#2111 Rename MenasAttachment to Attachment
53d2572
jakipatryk added a commit that referenced this issue Aug 17, 2022
@jakipatryk
#2111 Rename MenasReference to Reference
b04b08e
jakipatryk added a commit that referenced this issue Aug 17, 2022
@jakipatryk
#2111 Rename MenasObject to GenericObject
cc7c225
jakipatryk added a commit that referenced this issue Aug 17, 2022
@jakipatryk
#2111 Fix UI (caused by menasRef->ref change in AuditTrail)
1dd5e62
jakipatryk added a commit that referenced this issue Aug 17, 2022
@jakipatryk
#2111 Fix test
ba823bd
jakipatryk added a commit that referenced this issue Aug 18, 2022
@jakipatryk
#2111 Rename menas.rest in 3.0.0 run.md
90af44d
jakipatryk added a commit that referenced this issue Aug 18, 2022
@jakipatryk
#2111 Update deployment section to reflect REST API separation
7420cf0
jakipatryk added a commit that referenced this issue Aug 18, 2022
@jakipatryk
#2111 Change Menas config section to use new version configs
c89ff7a
jakipatryk added a commit that referenced this issue Aug 18, 2022
@jakipatryk
#2111 Change --menas-auth-... to --rest-api-...
6e61bf2
jakipatryk added a commit that referenced this issue Aug 18, 2022
@jakipatryk
#2111 After merge fix
5982570
lsulak added a commit that referenced this issue Aug 28, 2022
@lsulak
#2072 making naming consistent with PR #2111
fd8fb81
@jakipatryk jakipatryk self-assigned this Sep 1, 2022
jakipatryk added a commit that referenced this issue Sep 2, 2022
@jakipatryk
#2111 Undo changes done by mistake in Dockerfile of rest module
59fb486
jakipatryk added a commit that referenced this issue Sep 14, 2022
@jakipatryk
#2111 Update docs to reflect Menas to REST API change (#2116)
e9027e2
@dk1844 dk1844 mentioned this issue Nov 2, 2022
Merged
jakipatryk added a commit that referenced this issue Nov 4, 2022
@jakipatryk
#2111 Rename entities in code that mention Menas API (#2114)
5c666b0
@jakipatryk
Copy link
Collaborator Author

Release notes
Renamed Menas API mentions to REST API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakipatryk jakipatryk

Labels
refactoring Improving code quality, paying off tech debt, aligning API, cleanup of unused code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2111 Rename entities in code that mention Menas API AbsaOSS/enceladus
1 participant
@jakipatryk