Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove examples module from Enceladus #2145

Closed
benedeki opened this issue Nov 3, 2022 · 0 comments · Fixed by #2147
Closed

Remove examples module from Enceladus #2145

benedeki opened this issue Nov 3, 2022 · 0 comments · Fixed by #2147
Assignees
@benedeki
Labels
Conformance Conformance Job affected priority: medium Important but not urgent refactoring Improving code quality, paying off tech debt, aligning API, cleanup of unused code

Comments

@benedeki
Copy link
Collaborator

benedeki commented Nov 3, 2022

Background

Examples module with Custom Conformance rules doesn't make sense in the concept anymore.

Feature

Remove the module from the project completely. Keep the folder and other examples though.
@benedeki benedeki added refactoring Improving code quality, paying off tech debt, aligning API, cleanup of unused code Conformance Conformance Job affected priority: medium Important but not urgent labels Nov 3, 2022
@benedeki benedeki self-assigned this Nov 3, 2022
benedeki added a commit that referenced this issue Nov 3, 2022
@benedeki
#2145: Remove examples module from Enceladus
95f103a 
* removed the `examples` module
* updated `README.md`
This was referenced Nov 3, 2022
Closed
Merged
benedeki added a commit that referenced this issue Nov 7, 2022
@benedeki
#2145: Remove examples module from Enceladus (#2147)
104c1eb 
* removed the `examples` module
* updated `README.md`
* added `jakipatryk` into CODEOWNERS and developers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benedeki benedeki

Labels
Conformance Conformance Job affected priority: medium Important but not urgent refactoring Improving code quality, paying off tech debt, aligning API, cleanup of unused code
Projects
None yet
Milestone
No milestone
1 participant
@benedeki