Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept Dataset without conformance rules #2162

Closed
benedeki opened this issue Jan 16, 2023 · 1 comment · Fixed by #2174
Closed

Accept Dataset without conformance rules #2162

benedeki opened this issue Jan 16, 2023 · 1 comment · Fixed by #2174
Labels
feature New feature good first issue Good for newcomers priority: medium Important but not urgent Rest-API Rest-API component affected

Comments

@benedeki
Copy link
Collaborator

benedeki commented Jan 16, 2023 •
edited

Background

When Dataset definition is submitted to Rest-API, it fails if list of conformance rules is not defined.
For easier operation (and eventual phase out of Conformance), it would be natural that if the Conformance rules are not provided it's considered and empty list.

Feature

If Dataset (from za.co.absa.enceladus.model) has not defined property conformance during deserialization, consider it an empty list.

Proposed Solution

Solution Ideas:

  1. Setting the property's default value to be List.empty should suffice
  2. Verify then with Rest-APIs that insert a new Dataset or edit an existing one.
@benedeki benedeki added good first issue Good for newcomers feature New feature priority: medium Important but not urgent Rest-API Rest-API component affected labels Jan 16, 2023
@TebaleloS TebaleloS mentioned this issue Feb 16, 2023
Merged
TebaleloS added a commit that referenced this issue Feb 17, 2023
@TebaleloS
Fixes #2162 - addressed PR comments
cb05c73
TebaleloS added a commit that referenced this issue Feb 17, 2023
@TebaleloS
Fixes #2162 - addressed PR comments
0eb9c8d
TebaleloS added a commit that referenced this issue Feb 20, 2023
@TebaleloS
Fixes #2162 - rebased to base to branch
dc33da4
TebaleloS added a commit that referenced this issue Feb 21, 2023
@TebaleloS
Fixes #2162
9576b4f
TebaleloS added a commit that referenced this issue Feb 21, 2023
@TebaleloS
Fixes #2162 - applied requested changes
b41f44d
TebaleloS added a commit that referenced this issue Feb 21, 2023
@TebaleloS
Fixes #2162 - Fiexed versioning typo
2d4a722
benedeki pushed a commit that referenced this issue Feb 22, 2023
@TebaleloS
"Accept Dataset without conformance rules #2162" (#2174)
7cd5e3e 
* Difined List.empty as default value for comformance rules
@TebaleloS
Copy link
Collaborator

Release notes
Dataset conformance is now optional, if it is not defined it assigns an empty list as a default value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature good first issue Good for newcomers priority: medium Important but not urgent Rest-API Rest-API component affected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

"Accept Dataset without conformance rules #2162" AbsaOSS/enceladus
2 participants
@benedeki @TebaleloS