Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename action.yaml -> action.yml #42

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Conversation

jkremser
Copy link
Member

before
Screenshot 2022-06-23 at 13 35 27

after (using my fork)
Screenshot 2022-06-23 at 14 08 18

required by gh actions vscode plugin to work properly

Signed-off-by: Jirka Kremser jiri.kremser@gmail.com

…in to work properly

Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
Copy link
Collaborator

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe educate vscode instead? :)

@jkremser
Copy link
Member Author

Maybe educate vscode instead? :)

I've created the issue on their side at the same time - cschleiden/vscode-github-actions#163

The thing is that all the other gh actions we use in k8gb are just fine with the plugin, because they choose to use action.yml instead of .yaml so aligning here makes sense I think, even though we are right :D

Copy link
Collaborator

@kuritka kuritka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will probably take a while to update the vscode plugin. Changing "us" because of they doesn't support .yaml is not quite right, but on the other hand yml and yaml are equally valid, so I guess nothing will happen if we change the file extension.

Copy link
Collaborator

@ytsarev ytsarev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, convinced :D

@jkremser
Copy link
Member Author

😌

@jkremser jkremser merged commit 15d6e34 into AbsaOSS:main Jun 23, 2022
@jkremser jkremser deleted the yaml-yml branch June 23, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants