-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename action.yaml -> action.yml #42
Conversation
…in to work properly Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe educate vscode instead? :)
I've created the issue on their side at the same time - cschleiden/vscode-github-actions#163 The thing is that all the other gh actions we use in k8gb are just fine with the plugin, because they choose to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it will probably take a while to update the vscode plugin. Changing "us" because of they doesn't support .yaml is not quite right, but on the other hand yml and yaml are equally valid, so I guess nothing will happen if we change the file extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
alright, convinced :D
😌 |
before
![Screenshot 2022-06-23 at 13 35 27](https://user-images.githubusercontent.com/535866/175296253-3531c893-35a9-493f-8486-006708b6a506.png)
after (using my fork)
![Screenshot 2022-06-23 at 14 08 18](https://user-images.githubusercontent.com/535866/175296205-e752e857-bace-45fe-bad8-993a7a4d2041.png)
required by gh actions vscode plugin to work properly
Signed-off-by: Jirka Kremser jiri.kremser@gmail.com