Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console and logging dispatcher are printing internal model instead of producer api json #588

Closed
cerveada opened this issue Jan 30, 2023 · 2 comments · Fixed by #590
Closed

console and logging dispatcher are printing internal model instead of producer api json #588

cerveada opened this issue Jan 30, 2023 · 2 comments · Fixed by #590
Assignees
@cerveada
Labels
bug Something isn't working
Milestone
1.0.3

Comments

@cerveada
Copy link
Contributor

  • produce the same json as httpDispatcher
  • make the version configurable
@cerveada cerveada added the bug Something isn't working label Jan 30, 2023
@cerveada cerveada added this to the 1.0.3 milestone Jan 30, 2023
@cerveada cerveada self-assigned this Jan 30, 2023
@wajda
Copy link
Contributor

wajda commented Jan 30, 2023 •
edited
Loading

I understand it could be convenient for certain cases, but just wondering, is there any other specific use-case for which it is important? console and logging were added merely for logging/debugging purposes, they have never meant to produce output that could be used in production.

@cerveada
Copy link
Contributor Author

viewing/testing Databricks output on rest of the Spline

cerveada added a commit that referenced this issue Jan 30, 2023
@cerveada
spark agent #588 support apiVersion in logging and console dispatcher
9551ba0
@cerveada cerveada mentioned this issue Jan 30, 2023
Merged
cerveada added a commit that referenced this issue Jan 31, 2023
@cerveada
spark agent #588 print producer model in logging and console dispatcher
e02aff8
cerveada added a commit that referenced this issue Jan 31, 2023
@cerveada
spark agent #588 print producer model in logging and console dispatcher
5ddad3e
@wajda wajda linked a pull request Jan 31, 2023 that will close this issue
spark agent #588 print producer model in logging and console dispatcher #590
Merged
@wajda wajda closed this as completed Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cerveada cerveada

Labels
bug Something isn't working
Projects
Spline
Status: Done
Milestone
1.0.3
Development

Successfully merging a pull request may close this issue.

spark agent #588 print producer model in logging and console dispatcher AbsaOSS/spline-spark-agent
2 participants
@wajda @cerveada