Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style improvements #607

Closed
wajda opened this issue Feb 16, 2023 · 0 comments · Fixed by #643
Closed

Code style improvements #607

wajda opened this issue Feb 16, 2023 · 0 comments · Fixed by #643
Assignees
@wajda
Labels
Tech debt
Milestone
1.1.0

Comments

@wajda
Copy link
Contributor

wajda commented Feb 16, 2023

  • Unify layout, spaces etc throughout the code
  • Remove IDEA warnings (missing type annotations, unused imports, unnecessary braces etc)
  • SQL syntax: capitalize keywords and types, lowercase table and column names
@wajda wajda added this to the 1.1.0 milestone Feb 16, 2023
wajda added a commit that referenced this issue Mar 31, 2023
@wajda
issue #607 Auto-layout
090b6de
wajda added a commit that referenced this issue Mar 31, 2023
@wajda
issue #607 Format SQL statements. Fix upper/lower case.
5e62438
wajda added a commit that referenced this issue Mar 31, 2023
@wajda
issue #607 Fix some IDEA code analysis warnings
5d307bf
@wajda wajda mentioned this issue Mar 31, 2023
Merged
wajda added a commit that referenced this issue Mar 31, 2023
@wajda
issue #607 Auto-layout
4db4e61
wajda added a commit that referenced this issue Mar 31, 2023
@wajda
issue #607 Format SQL statements. Fix upper/lower case.
416cb60
wajda added a commit that referenced this issue Mar 31, 2023
@wajda
issue #607 Fix some IDEA code analysis warnings
dc5837f
wajda added a commit that referenced this issue Mar 31, 2023
@wajda
issue #607 Auto-layout
ce20f51
wajda added a commit that referenced this issue Mar 31, 2023
@wajda
issue #607 Format SQL statements. Fix upper/lower case.
26e9263
wajda added a commit that referenced this issue Mar 31, 2023
@wajda
issue #607 Fix some IDEA code analysis warnings
f41abfa
wajda added a commit that referenced this issue Mar 31, 2023
@wajda
issue #607 Auto-layout
b9005ab
wajda added a commit that referenced this issue Mar 31, 2023
@wajda
issue #607 Format SQL statements. Fix upper/lower case.
a81b239
wajda added a commit that referenced this issue Mar 31, 2023
@wajda
issue #607 Fix some IDEA code analysis warnings
d7b69a9
wajda added a commit that referenced this issue Mar 31, 2023
@wajda
issue #607 Auto-layout
4a18e14
wajda added a commit that referenced this issue Mar 31, 2023
@wajda
issue #607 Format SQL statements. Fix upper/lower case.
bfdac84
wajda added a commit that referenced this issue Mar 31, 2023
@wajda
issue #607 Fix some IDEA code analysis warnings
7ae4292
@wajda wajda self-assigned this Mar 31, 2023
wajda added a commit that referenced this issue Mar 31, 2023
@wajda
issue #607 Auto-layout
5e51a2c
wajda added a commit that referenced this issue Mar 31, 2023
@wajda
issue #607 Format SQL statements. Fix upper/lower case.
8175de2
wajda added a commit that referenced this issue Mar 31, 2023
@wajda
issue #607 Fix some IDEA code analysis warnings
76be07c
wajda added a commit that referenced this issue Mar 31, 2023
@wajda
issue #607 tech debts: code formatting, cleaning etc
5f85dfe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wajda wajda

Labels
Tech debt
Projects
Spline
Status: Done
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

Feature/spline spark agent 607 code style etc AbsaOSS/spline-spark-agent
1 participant
@wajda