Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YAML config breaks on non-string values #616

Closed
wajda opened this issue Feb 24, 2023 · 0 comments · Fixed by #617
Closed

YAML config breaks on non-string values #616

wajda opened this issue Feb 24, 2023 · 0 comments · Fixed by #617
Assignees
@wajda
Labels
bug Something isn't working
Milestone
1.0.5

Comments

@wajda
Copy link
Contributor

wajda commented Feb 24, 2023

This is a continuation of #610

This is fixed in commons-configuration:1.7 https://issues.apache.org/jira/browse/CONFIGURATION-432

Unfortunately, Spark 2.4 depends on version 1.6

There already were other issues with YAML as version 1.2 being interpreted as float and there may be more.
Other properties sources just treat everything as string and do the conversion once it is asked for. Maybe we could use Yaml the same way.
@wajda wajda self-assigned this Feb 24, 2023
@wajda wajda added this to the 1.0.5 milestone Feb 24, 2023
@wajda wajda added the bug Something isn't working label Feb 24, 2023
wajda added a commit that referenced this issue Feb 24, 2023
@wajda
issue #616 YAML config to convert single-valued non-string properties…
768baf6 
… to String for better interoperability with other types of Configuration.
@wajda wajda mentioned this issue Feb 24, 2023
Merged
@wajda wajda linked a pull request Feb 24, 2023 that will close this issue
issue #616 YAML config to convert single-valued non-string properties… #617
Merged
wajda added a commit that referenced this issue Feb 27, 2023
@wajda
issue #616 PR comments: add a unit test for getXXX() as XXX type
284696b
wajda added a commit that referenced this issue Feb 28, 2023
@wajda
issue #616 YAML config to convert single-valued non-string properties… (
4e857c3 
#617)

* issue #616 YAML config to convert single-valued non-string properties to String for better interoperability with other types of Configuration.

* issue #616 PR comments: add a unit test for `getXXX()` as XXX type
@wajda wajda closed this as completed Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wajda wajda

Labels
bug Something isn't working
Projects
Spline
Status: Done
Milestone
1.0.5
Development

Successfully merging a pull request may close this issue.

issue #616 YAML config to convert single-valued non-string properties… AbsaOSS/spline-spark-agent
1 participant
@wajda