Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handling listquery expression which is result of IN clause #701

Merged
merged 11 commits into from
Jun 20, 2023
Merged

handling listquery expression which is result of IN clause #701

merged 11 commits into from
Jun 20, 2023

Conversation

uday1409
Copy link
Contributor

@uday1409 uday1409 commented Jun 15, 2023 •
edited by wajda
Loading

fixes #700

@uday1409 uday1409 mentioned this pull request Jun 15, 2023
Closed
wajda
wajda previously approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@wajda wajda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM excepts for a minor code style comment

core/src/main/scala/za/co/absa/spline/harvester/converter/ExpressionConverter.scala Outdated Show resolved Hide resolved
@wajda wajda requested a review from cerveada June 15, 2023 20:14
@uday1409 @wajda
Update core/src/main/scala/za/co/absa/spline/harvester/converter/Expr…
8670a97 
…essionConverter.scala

Co-authored-by: Alex Vayda <oleksandr.vayda@gmail.com>
@uday1409
Copy link
Contributor Author

@wajda @cerveada can you please review it again

wajda
wajda previously approved these changes Jun 16, 2023
View reviewed changes
Copy link
Contributor

@wajda wajda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jun 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

wajda
wajda approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@wajda wajda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
No worries about cleaning a PR, we'll merge it with squashing, there will be a single commit with your name.

@wajda wajda merged commit b8dc9e5 into AbsaOSS:develop Jun 20, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wajda wajda wajda approved these changes

@cerveada cerveada cerveada approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lineage is not getting tracked for subquery IN
3 participants
@uday1409 @wajda @cerveada