Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variables naming #616

Closed
rvvincelli opened this issue Mar 25, 2020 · 3 comments · Fixed by #618
Closed

Environment variables naming #616

rvvincelli opened this issue Mar 25, 2020 · 3 comments · Fixed by #618
Assignees
Labels
Milestone

Comments

@rvvincelli
Copy link

rvvincelli commented Mar 25, 2020

Describe the bug

Hi team, thanks a lot for this project! We are trying this out in a production setting :)

Not really a bug but I thought this was the best place anyway. Your compose uses variables like spline.database.connectionUrl, directly mapping to the webenv variables. Not really convention-friendly i.e. VARIABLE; Among other things, this is also an issue on some provisioners, such as Azure Container Instances - deploying is not possible because the naming convention - enforced by ACI - prevents it. So something like a wrapper var SPLINE_DATABASE_CONNECTION_URL could help.

Thanks,

cc @patrickdehoon

@rvvincelli rvvincelli added the bug label Mar 25, 2020
@Zejnilovic
Copy link
Contributor

Hello @rvvincelli , please check this issue #579 and tell me if it helps.

@wajda
Copy link
Contributor

wajda commented Mar 25, 2020

Makes sense. We'l include it in one the following releases. Meantime please use the workaround from the previous post.

@wajda wajda added this to the 0.5.0 milestone Mar 25, 2020
@wajda wajda changed the title Docker variables naming Environment variables naming Mar 25, 2020
wajda added a commit that referenced this issue Mar 25, 2020
@wajda wajda self-assigned this Mar 25, 2020
@rvvincelli
Copy link
Author

Hello @rvvincelli , please check this issue #579 and tell me if it helps.

That's a very good point - thanks!!

wajda added a commit that referenced this issue Mar 27, 2020
wajda added a commit that referenced this issue Mar 27, 2020
@wajda wajda reopened this Mar 27, 2020
@wajda wajda closed this as completed Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants