Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client UI WebJar should not have any bytecode dependencies #635

Closed
wajda opened this issue Apr 9, 2020 · 2 comments
Closed

Client UI WebJar should not have any bytecode dependencies #635

wajda opened this issue Apr 9, 2020 · 2 comments
Labels
Milestone

Comments

@wajda
Copy link
Contributor

wajda commented Apr 9, 2020

Describe the bug

This

[wajda@alex-xps client-ui]$ mvn dependency:tree

reveals transitive dependencies that should not be there:

[INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ client-ui ---
[INFO] za.co.absa.spline:client-ui:jar:0.5.0-SNAPSHOT
[INFO] +- za.co.absa.spline:consumer-rest-core:jar:0.5.0-SNAPSHOT:compile
[INFO] |  +- javax.servlet:javax.servlet-api:jar:3.1.0:compile
[INFO] |  +- za.co.absa.spline:commons:jar:0.5.0-SNAPSHOT:compile
[INFO] |  |  +- za.co.absa.commons:commons_2.12:jar:0.0.7:compile
[INFO] |  |  +- commons-configuration:commons-configuration:jar:1.10:compile
[INFO] |  |  |  +- commons-lang:commons-lang:jar:2.6:compile
[INFO] |  |  |  \- commons-logging:commons-logging:jar:1.1.1:compile
[INFO] |  |  \- org.slf4s:slf4s-api_2.12:jar:1.7.25:compile
[INFO] |  |     \- org.slf4j:slf4j-api:jar:1.7.25:compile
[INFO] |  +- za.co.absa.spline:consumer-services:jar:0.5.0-SNAPSHOT:compile
[INFO] |  |  \- za.co.absa.spline:persistence:jar:0.5.0-SNAPSHOT:compile
[INFO] |  |     +- org.apache.commons:commons-lang3:jar:3.9:compile
[INFO] |  |     +- org.apache.httpcomponents:httpclient:jar:4.5.10:compile
[INFO] |  |     |  +- org.apache.httpcomponents:httpcore:jar:4.4.12:compile
[INFO] |  |     |  \- commons-codec:commons-codec:jar:1.13:compile
[INFO] |  |     +- com.arangodb:arangodb-java-driver:jar:6.6.0:compile
[INFO] |  |     |  \- com.arangodb:velocypack:jar:2.1.1:compile
[INFO] |  |     +- com.arangodb:velocypack-module-scala_2.12:jar:1.2.0:compile
[INFO] |  |     \- org.scala-lang.modules:scala-java8-compat_2.12:jar:0.9.0:compile
[INFO] |  +- commons-io:commons-io:jar:2.6:compile
[INFO] |  +- com.typesafe:config:jar:1.4.0:compile
[INFO] |  +- org.springframework:spring-webmvc:jar:5.2.2.RELEASE:compile
[INFO] |  |  +- org.springframework:spring-aop:jar:5.2.2.RELEASE:compile
[INFO] |  |  +- org.springframework:spring-beans:jar:5.2.2.RELEASE:compile
[INFO] |  |  +- org.springframework:spring-context:jar:5.2.2.RELEASE:compile
[INFO] |  |  +- org.springframework:spring-core:jar:5.2.2.RELEASE:compile
[INFO] |  |  |  \- org.springframework:spring-jcl:jar:5.2.2.RELEASE:compile
[INFO] |  |  +- org.springframework:spring-expression:jar:5.2.2.RELEASE:compile
[INFO] |  |  \- org.springframework:spring-web:jar:5.2.2.RELEASE:compile
[INFO] |  +- com.fasterxml.jackson.module:jackson-module-scala_2.12:jar:2.10.1:compile
[INFO] |  |  +- com.fasterxml.jackson.core:jackson-core:jar:2.10.1:compile
[INFO] |  |  +- com.fasterxml.jackson.core:jackson-annotations:jar:2.10.1:compile
[INFO] |  |  +- com.fasterxml.jackson.core:jackson-databind:jar:2.10.1:compile
[INFO] |  |  \- com.fasterxml.jackson.module:jackson-module-paranamer:jar:2.10.1:compile
[INFO] |  |     \- com.thoughtworks.paranamer:paranamer:jar:2.8:compile
[INFO] |  \- io.swagger:swagger-annotations:jar:1.6.0:compile
[INFO] +- org.scala-lang:scala-library:jar:2.12.10:compile
[INFO] +- org.scalatest:scalatest_2.12:jar:3.1.0:test
[INFO] |  +- org.scalatest:scalatest-compatible:jar:3.1.0:test
[INFO] |  +- org.scalactic:scalactic_2.12:jar:3.1.0:test
[INFO] |  +- org.scala-lang:scala-reflect:jar:2.12.10:compile
[INFO] |  \- org.scala-lang.modules:scala-xml_2.12:jar:1.2.0:test
[INFO] +- org.scalatestplus:mockito-1-10_2.12:jar:3.1.0.0:test
[INFO] |  \- org.mockito:mockito-core:jar:3.2.0:test
[INFO] |     +- net.bytebuddy:byte-buddy:jar:1.10.3:test
[INFO] |     +- net.bytebuddy:byte-buddy-agent:jar:1.10.3:test
[INFO] |     \- org.objenesis:objenesis:jar:2.6:test
[INFO] \- com.google.code.findbugs:jsr305:jar:3.0.2:provided
[INFO] ------------------------------------------------------------------------

Expected behaviour

WebJar contains no bytecode and should have no dependencies to bytecode artefacts

@wajda wajda added the bug label Apr 9, 2020
@wajda wajda added this to the 0.5.0 milestone Apr 9, 2020
@wajda
Copy link
Contributor Author

wajda commented Apr 9, 2020

CC @Zejnilovic

@Zejnilovic
Copy link
Contributor

Looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants