Spline 831 Producer API enhancement #860
Conversation
…it extension class to prevent Swagger from generating unwanted properties out of them.
…n | Attribute).childRefs`
…well as Swagger def
wajda
force-pushed
the
spline-831-producer-api-enhancement
branch
from
ee4bea7
to
36cf567
Compare
| def params: Map[String, Any] | ||
| def extra: Map[String, Any] | ||
| def `type`: String | ||
| def `type`: Operation.Type |
There was a problem hiding this comment.
What is the logic behind the naming? Sometime `type` and other time _type?
There was a problem hiding this comment.
yes, a lot of confusion here... Originally the logic was to have all technical (non-business) props to be prefixed with underscore, just to avoid confusion in situations like when you add a business property with a similar name. For example operation type "Filter" vs type "transformation" or vs type "za.co.absa....operation.FilterOperation" -- here every type means different things and is supposed to be analyzed on different application layers. It worked well before and in general, but in case with Arango, since we don't have a control on how JSON fields are mapped on the class properties in Arango driver this convention leaked into the domain model and started making noise there. And also _ is a reserved for Arango stuff, so I think we need to get rid of using that prefix convention.
producer-model/src/main/scala/za/co/absa/spline/producer/model/v1_1/AttrOrExprRef.scala
Show resolved
Hide resolved
producer-model/src/main/scala/za/co/absa/spline/producer/model/v1_1/operations.scala
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
childIdstochildRefsin expression and attributesnameproperty to execution plan and operationsdurationNsproperty to the execution eventkafka-gatewaymodule (Rename package: za.co.absa.spline.producer.kafkatoza.co.absa.spline.gateway.kafka` for consistency with the REST gateway #846)