Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semi-automated tagging and generating GH Release draft to CICD #37

Conversation

jakipatryk
Copy link
Collaborator

@jakipatryk jakipatryk commented Jan 12, 2024

  • changed JDK version to openjdk@1.17.01 in publish job, as this was already needed in CI
  • spit release workflow into two:
    • release_draft with:
      • tag job that creates and pushes a git tag (name is specified as the workflow input)
      • release job that creates a draft release with notes derived from closed issues
    • release_publish with publish job that was previously in the release workflow; now it should be triggered once release created by release_draft is finalised and converted from draft to release

Copy link

JaCoCo code coverage report - springdoc-openapi-scala-1

Overall Project 95.57% 🍏

There is no coverage information present for the Files changed

Copy link

JaCoCo code coverage report - springdoc-openapi-scala-2

Overall Project 95.57% 🍏

There is no coverage information present for the Files changed

@jakipatryk jakipatryk marked this pull request as ready for review January 12, 2024 08:32
dk1844
dk1844 previously approved these changes Jan 12, 2024
Copy link

@dk1844 dk1844 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see @miroslavpojer's work being used so quickly

@jakipatryk jakipatryk added the work in progress Work on this item is not yet finished (mainly intended for PRs) label Jan 12, 2024
@jakipatryk jakipatryk changed the title Add semi-automated tagging and generating GH Release draft to release workflow Add semi-automated tagging and generating GH Release draft to CICD Jan 12, 2024
@jakipatryk jakipatryk removed the work in progress Work on this item is not yet finished (mainly intended for PRs) label Jan 12, 2024
Copy link
Collaborator

@miroslavpojer miroslavpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • pulled
  • code review

@jakipatryk jakipatryk merged commit f32504b into main Jan 12, 2024
2 checks passed
@jakipatryk jakipatryk deleted the feature/add-semi-automatic-tagging-and-generating-gh-release-draft-to-release-workflow branch January 12, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants