New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation fail with 2.067-rc1 #1

Closed
NCrashed opened this Issue Mar 17, 2015 · 9 comments

Comments

Projects
None yet
2 participants
@NCrashed
Contributor

NCrashed commented Mar 17, 2015

Upcoming release of 2.067 is breaking compilation:

Building dauth 0.6.1 configuration "library", build type debug.
Running dmd...
../../../.dub/packages/dauth-0.6.1/src/dauth/sha.d(748): Warning: instead of C-style syntax, use D-style syntax 'ubyte[8] bits'
../../../.dub/packages/dauth-0.6.1/src/dauth/sha.d(772): Warning: instead of C-style syntax, use D-style syntax 'ubyte[16] bits'
@Abscissa

This comment has been minimized.

Show comment
Hide comment
@Abscissa

Abscissa Mar 17, 2015

Owner

Engh, that's one reason I really wish dub wouldn't try to blindly build every file in the source. That module only gets imported on older DMDs that don't have SHA-2 in Phobos (it's a copy of an older std.digest.sha modified to include SHA-2), on other DMDs it shouldn't even be getting compiled at all.

Well anyway, SHA-2 has been in Phobos for awhile now (about a year I think), so it may finally be time to just rip that module out entirely.

Owner

Abscissa commented Mar 17, 2015

Engh, that's one reason I really wish dub wouldn't try to blindly build every file in the source. That module only gets imported on older DMDs that don't have SHA-2 in Phobos (it's a copy of an older std.digest.sha modified to include SHA-2), on other DMDs it shouldn't even be getting compiled at all.

Well anyway, SHA-2 has been in Phobos for awhile now (about a year I think), so it may finally be time to just rip that module out entirely.

@Abscissa

This comment has been minimized.

Show comment
Hide comment
@Abscissa

Abscissa Mar 17, 2015

Owner

Hmm, just checked, Phobos gained SHA-2 in v2.066. Ok, I'll see about fixing this.

FWIW there is another bug involved here: Last I checked, dub had a bug where it was using "warnings as errors" even though "informational warnings" is supposed to be dub's default. So really this issue shouldn't have caused the build to fail. But of course, even then, this issue would still need fixed anyway, so it's kinda moot.

Owner

Abscissa commented Mar 17, 2015

Hmm, just checked, Phobos gained SHA-2 in v2.066. Ok, I'll see about fixing this.

FWIW there is another bug involved here: Last I checked, dub had a bug where it was using "warnings as errors" even though "informational warnings" is supposed to be dub's default. So really this issue shouldn't have caused the build to fail. But of course, even then, this issue would still need fixed anyway, so it's kinda moot.

@NCrashed

This comment has been minimized.

Show comment
Hide comment
@NCrashed

NCrashed Mar 25, 2015

Contributor

2.067 is released but the issue still persists

Contributor

NCrashed commented Mar 25, 2015

2.067 is released but the issue still persists

@NCrashed

This comment has been minimized.

Show comment
Hide comment
@NCrashed

NCrashed Mar 25, 2015

Contributor

I've made PR with simple fixes to be able use library with 2.067. I know that isn't the way you want to fix it (as I understand, you would like to throw away custom sha module and use phobos one, but problem in dub makes semantic checks in deprecated module), but it could be simple and fast solution until major solution isn't implemented.

Contributor

NCrashed commented Mar 25, 2015

I've made PR with simple fixes to be able use library with 2.067. I know that isn't the way you want to fix it (as I understand, you would like to throw away custom sha module and use phobos one, but problem in dub makes semantic checks in deprecated module), but it could be simple and fast solution until major solution isn't implemented.

@Abscissa Abscissa closed this in #2 Mar 25, 2015

@Abscissa

This comment has been minimized.

Show comment
Hide comment
@Abscissa

Abscissa Mar 25, 2015

Owner

Merged, thanks!

Owner

Abscissa commented Mar 25, 2015

Merged, thanks!

@NCrashed

This comment has been minimized.

Show comment
Hide comment
@NCrashed

NCrashed Mar 25, 2015

Contributor

Thanks! Could you add new version tag for dub registry?

Contributor

NCrashed commented Mar 25, 2015

Thanks! Could you add new version tag for dub registry?

@Abscissa

This comment has been minimized.

Show comment
Hide comment
@Abscissa

Abscissa Mar 25, 2015

Owner

Already on it...

Owner

Abscissa commented Mar 25, 2015

Already on it...

@Abscissa

This comment has been minimized.

Show comment
Hide comment
@Abscissa

Abscissa Mar 25, 2015

Owner

Done. Tagged v0.6.2.

Owner

Abscissa commented Mar 25, 2015

Done. Tagged v0.6.2.

@NCrashed

This comment has been minimized.

Show comment
Hide comment
@NCrashed

NCrashed Mar 25, 2015

Contributor

Thank you!

Contributor

NCrashed commented Mar 25, 2015

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment