-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compilation fail with 2.067-rc1 #1
Comments
Engh, that's one reason I really wish dub wouldn't try to blindly build every file in the source. That module only gets imported on older DMDs that don't have SHA-2 in Phobos (it's a copy of an older std.digest.sha modified to include SHA-2), on other DMDs it shouldn't even be getting compiled at all. Well anyway, SHA-2 has been in Phobos for awhile now (about a year I think), so it may finally be time to just rip that module out entirely. |
Hmm, just checked, Phobos gained SHA-2 in v2.066. Ok, I'll see about fixing this. FWIW there is another bug involved here: Last I checked, dub had a bug where it was using "warnings as errors" even though "informational warnings" is supposed to be dub's default. So really this issue shouldn't have caused the build to fail. But of course, even then, this issue would still need fixed anyway, so it's kinda moot. |
2.067 is released but the issue still persists |
I've made PR with simple fixes to be able use library with 2.067. I know that isn't the way you want to fix it (as I understand, you would like to throw away custom sha module and use phobos one, but problem in dub makes semantic checks in deprecated module), but it could be simple and fast solution until major solution isn't implemented. |
Merged, thanks! |
Thanks! Could you add new version tag for dub registry? |
Already on it... |
Done. Tagged v0.6.2. |
Thank you! |
Upcoming release of 2.067 is breaking compilation:
The text was updated successfully, but these errors were encountered: