Update js and some other things #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
elalemanyo
commented
Oct 10, 2021
•
elalemanyo
commented
- Update js (Access vendored JS directly via chartkick gem #1)
- Update author name
- Remove travis and add GitHub actions
UliKuch
approved these changes
Oct 11, 2021
rstammer
approved these changes
Oct 15, 2021
There was a problem hiding this comment.
Awesome work, @elalemanyo.
Super happy that you have tackled this. Tried it out on my machine, all good and works perfect. I really appreciate the smart move employing webpacker to load chartkick, which is much better than the workaround we had before.
Well done, @elalemanyo and I owe you some 🍨 😄
| @@ -1,6 +1,6 @@ | |||
| The MIT License (MIT) | |||
|
|
|||
| Copyright (c) 2019 Robin Neumann | |||
There was a problem hiding this comment.
Haha, good catch @elalemanyo :)
This was referenced Oct 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.