Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set adapter addr on install_adapter #21

Merged
merged 7 commits into from
Jul 18, 2023
Merged

Set adapter addr on install_adapter #21

merged 7 commits into from
Jul 18, 2023

Conversation

Buckram123
Copy link
Contributor

  • Sets and returns Addr of installed adapter
  • Tests for install_adapter functionality with tests for install_app

Checklist

  • CI is green.
  • Changelog updated.

@cloudflare-pages
Copy link

cloudflare-pages bot commented Jul 12, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f34d0f5
Status: ✅  Deploy successful!
Preview URL: https://de32dec5.abstract-docs.pages.dev
Branch Preview URL: https://set-adapter-addr-in-install.abstract-docs.pages.dev

View logs

@Buckram123 Buckram123 marked this pull request as draft July 12, 2023 15:04
@Buckram123 Buckram123 marked this pull request as ready for review July 13, 2023 10:50
@Buckram123
Copy link
Contributor Author

Ok nightly clippy got new lints

@Buckram123 Buckram123 marked this pull request as draft July 13, 2023 11:36
@Buckram123 Buckram123 marked this pull request as ready for review July 13, 2023 12:16
@Buckram123 Buckram123 mentioned this pull request Jul 13, 2023
Merged
CyberHoward
CyberHoward reviewed Jul 14, 2023
View reviewed changes
Copy link
Contributor

@CyberHoward CyberHoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should get rid of / make private the install_module function on the account, so there's only install_app or install_adapter.

@CyberHoward CyberHoward merged commit daa409c into main Jul 18, 2023
11 checks passed
@CyberHoward CyberHoward deleted the set-adapter-addr-in-install_adapter branch July 18, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyberHoward CyberHoward CyberHoward approved these changes

@Kayanski Kayanski Awaiting requested review from Kayanski

Assignees
No one assigned
Labels
account interface native
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Buckram123 @CyberHoward