Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix automatic ibc client install" #361

Merged
merged 2 commits into from
May 25, 2024

Conversation

Kayanski
Copy link
Contributor

Reverts #346

Copy link

cloudflare-pages bot commented May 24, 2024

Deploying abstract-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: ee4f43d
Status: ✅  Deploy successful!
Preview URL: https://635c546b.abstract-docs.pages.dev
Branch Preview URL: https://revert-346-fix-remove-automa.abstract-docs.pages.dev

View logs

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2024

Codecov Report

Attention: Patch coverage is 87.58621% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 85.8%. Comparing base (21e55ad) to head (ee4f43d).
Report is 150 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
framework/contracts/account/manager/src/error.rs 100.0% <ø> (ø)
...rk/contracts/native/module-factory/src/commands.rs 99.0% <ø> (ø)
...ckages/abstract-interface/src/native/ibc_client.rs 44.0% <ø> (ø)
...ramework/packages/abstract-std/src/core/manager.rs 66.6% <ø> (ø)
...ramework/contracts/account/manager/src/contract.rs 98.1% <90.0%> (+<0.1%) ⬆️
...packages/abstract-interface/src/account/manager.rs 54.9% <0.0%> (-1.0%) ⬇️
framework/packages/abstract-client/src/account.rs 85.8% <0.0%> (+0.3%) ⬆️
...ramework/contracts/account/manager/src/commands.rs 95.1% <89.3%> (+<0.1%) ⬆️

... and 148 files with indirect coverage changes

@Kayanski Kayanski merged commit 2e2e1c3 into main May 25, 2024
13 checks passed
@Kayanski Kayanski deleted the revert-346-fix/remove-automatic-ibc-client-install branch May 25, 2024 17:09
Kayanski added a commit that referenced this pull request May 25, 2024
CyberHoward added a commit that referenced this pull request Jun 7, 2024
* Revert "Revert "Fix automatic ibc client install" (#361)"

This reverts commit 2e2e1c3.

* nit

---------

Co-authored-by: cyberhoward <cyberhoward@protonmail.com>
Co-authored-by: CyberHoward <88450409+CyberHoward@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants