-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daemon Sender separation #387
Draft
Kayanski
wants to merge
58
commits into
main
Choose a base branch
from
nicolas/orc-126-daemon-should-become-a-wrapper-around-sender-types
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Daemon Sender separation #387
Kayanski
wants to merge
58
commits into
main
from
nicolas/orc-126-daemon-should-become-a-wrapper-around-sender-types
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying cw-orchestrator with Cloudflare Pages
|
Co-authored-by: CyberHoward <88450409+CyberHoward@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at separating the daemon and the sender to be able to compose with senders and queriers.
I removed the Arc wrapper around the Sender because the
SenderTrait
trait needs theset_options
method to take a mutable reference, which arc can't do because it can't mutate the underlying object.When using a Mutex to allow for mutability, the async methods of the trait error because of a Send bound that is not available.
We will need to think about that, if we want the Sender to be copiable