Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate 'rqd.rqutil.checkAndCreateUser' #1136

Open
donalm opened this issue Apr 26, 2022 · 0 comments
Open

Deprecate 'rqd.rqutil.checkAndCreateUser' #1136

donalm opened this issue Apr 26, 2022 · 0 comments
Labels
enhancement Improvement to an existing feature

Comments

@donalm
Copy link
Contributor

donalm commented Apr 26, 2022

There's a function in rqd.util that (depending on your configuration file) will try to create the user account for a job's user if the account doesn't already exist. The function doesn't have any means to ensure the User ID for the new account is aligned with whatever's expected by fileservers, etc. so I'm not sure how this might be useful? Does anyone use this for production or testing? Or can anyone suggest a use for it that I haven't considered?

There's a TODO on the method:

    # TODO(gregdenton): Add Windows and Mac support here. (Issue #61)

I'd suggest that instead of making this work on other OSes, the feature just be removed. If users try to enable it, it probably won't do what they hope it will anyhow, and has the potential to leave the system in a confusing inconsistent state, where a user account appears to exist, but doesn't have the expected credentials or authorizations.

@donalm donalm added the enhancement Improvement to an existing feature label Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant