Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve FrameRange/FrameSet string representations #83

Open
bcipriano opened this issue Dec 20, 2018 · 0 comments
Open

improve FrameRange/FrameSet string representations #83

bcipriano opened this issue Dec 20, 2018 · 0 comments
Labels
enhancement Improvement to an existing feature triaged Issue has been screened and prioritized by a project lead

Comments

@bcipriano
Copy link
Collaborator

The old C++ implementation has smart string representations - sequences of frames are grouped by range and step. I believe this only really affects visual representations of the frame range; the backend deals with only flattened lists of frames.

See the old libFileSequence test code[1] for examples of how the grouping works.

Our existing code uses very simple string representations - flat comma-separated lists of frames contained within. By Python and Java implementations should be switched to match the old C++ library.

[1] https://github.com/imageworks/OpenCue/blob/165d4c54b5e9ad55ec84416d8fdc79761174cabf/libFileSequence/test/FileSequenceTest.cpp#L800

@bcipriano bcipriano added the enhancement Improvement to an existing feature label May 22, 2019
@bcipriano bcipriano added the triaged Issue has been screened and prioritized by a project lead label Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to an existing feature triaged Issue has been screened and prioritized by a project lead
Projects
None yet
Development

No branches or pull requests

1 participant