-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'use_variant_shortlinks' config entry ignore by rez-cp #1701
Comments
We don't support JSON config files. Is it a typo? |
I definitely saved my file as .json, but I suspect it was loaded by PyYAML without me noticing. I've moved it to a .yaml. This is the contents of the config file I was testing.
Edit: I confirmed that I can use a YAML loader to load this dict, even though it was user error on my part. |
Just to be sure that your config is loaded properly, would you mind giving me the result of |
Good point. I've just now confirmed that
|
Umm, that's an error in our code. Lines 244 to 247 in a13f7bb
If should be: raise PackageCopyError(
"Cannot copy source variant %s - its root does not appear to "
"be present on disk (%s)." % (src_variant.uri, variant_root)
) |
Hello,
I've disabled variant shortlinks for my windows machine using a rez config json file. I went to rez-cp a package to my repository and noticed that rez-cp was still trying to create a _v shortlink folder. It fails due to permissions, but rez-cp continues on and copies the full variant folder anwyay.
Environment
To Reproduce
Expected behavior
I expect rez-cp to skip the shortlink creation when the config specifies to do so.
Actual behavior
A _v folder is created even though my config is disabling them.
The text was updated successfully, but these errors were encountered: