Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package caching does not work on windows due to device not being implemented in py2 on Windows #912

Closed
instinct-vfx opened this issue Jul 22, 2020 · 1 comment · Fixed by #917
Labels
bug os:windows Windows-specific

Comments

@instinct-vfx
Copy link
Contributor

Package caching is by default configured to not allow caching on the same device. The check for "same device" does not work on windows though and always results in a false positive.

There are multiple possible ways to fix this:

  • Add version and platform checking to said function checking for the device. python < 3.4 and windows being problematic. Not sure how to deal with this though as this would make the setting be ignored completely.
  • Add version and platform checking to the default config (similar to coloring). That would be rather transparent?

Oppinions?

@instinct-vfx instinct-vfx added bug os:windows Windows-specific labels Jul 22, 2020
@nerdvegas
Copy link
Contributor

given this is deprecated py2 only, and that checking py version in config would require more work, I think simply ignoring the device in this case would suffice. Even if pkg caching occurred on the same device, it would hardy be a big issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug os:windows Windows-specific
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants