Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installed package not including latest module #934

Closed
davidlatwe opened this issue Aug 13, 2020 · 0 comments · Fixed by #935
Closed

Installed package not including latest module #934

davidlatwe opened this issue Aug 13, 2020 · 0 comments · Fixed by #935

Comments

@davidlatwe
Copy link
Contributor

Problem

I have my rezconfig.py set package_definition_python_path="/path/to/shared/code" and I include the shared module with include decorator for my package's commands function.

The included module was copied correctly into {package.root}/.rez/include directory when I run rez-build --install. But the installed package not able to pick up the correct copy of include module after I re-build with source have changed.

Cause

I found that it was because the copied shared module was named with hash string, which is fine but then Rez did not pick the right one, only the first one it globed.

https://github.com/nerdvegas/rez/blob/f81c721c079abe99746dce80853da45351a2b683/src/rez/utils/sourcecode.py#L324-L328

Maybe we could drop naming shared module with hash string ? Just hash it again when trying to access them.
I'll try submit a PR as a proposal of solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant