feat: align derivation accross ecosystem #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2664 +/- ##
==========================================
+ Coverage 67.53% 67.55% +0.02%
==========================================
Files 69 71 +2
Lines 8430 8713 +283
==========================================
+ Hits 5693 5886 +193
- Misses 2737 2827 +90 ☔ View full report in Codecov by Sentry. |
xlc
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, there is no common ecosystem wide approach to derive accounts from xcm-origins. This PR adds a converter both used by
The converter was introduced by Gavin Wood in order to create a general purpose conversion. The idea behind this converter is that a user
User1fromChainAhas the ability to have a unique account on any other chain in the ecosystem. This so called remote account can only be controlled fromUser1fromChainA.Motivation and Context
Allows to have remote accounts on Acala for all purposes a native account could be used. Especially useful for when we do not want to deteriorate UX by switching networks in the UI.
How Has This Been Tested?
In production at Centrifuge and Moonbeam for quite some time.