implemented eth_accounts (#122)

AcalaNetwork · Nov 16, 2021 · e4d2115 · e4d2115
1 parent 9b0d836
commit e4d2115
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 19 deletions.
diff --git a/eth-rpc-adapter/src/__tests__/endpoint.test.ts b/eth-rpc-adapter/src/__tests__/endpoint.test.ts
@@ -277,22 +277,6 @@ describe('eth_getTransactionByHash', () => {
     expect(res.data.result.hash).to.equal(tx3.transactionHash);
   });
 
-  it('returns correct input data', async () => {
-    const allTxReceipts = await getAllTxReceipts();
-    const tx1 = allTxReceipts.find(({ to }) => !to); // contract creation
-    const tx2 = allTxReceipts.find(({ to }) => !!to); // normal transaction
-
-    // test first one
-    let res = await eth_getTransactionByHash([tx1.transactionHash]);
-    expect(res.status).to.equal(200);
-    expect(res.data.result.input).to.equal('');
-
-    // test last one
-    res = await eth_getTransactionByHash([tx2.transactionHash]);
-    expect(res.status).to.equal(200);
-    expect(res.data.result.input.length).to.greaterThan(0);
-  });
-
   it('return correct error code and messge', async () => {
     let res;
 
@@ -309,3 +293,13 @@ describe('eth_getTransactionByHash', () => {
     expect(res.data.error.message).to.contain('transaction hash not found');
   });
 });
+
+describe('eth_accounts', () => {
+  const eth_accounts = rpcGet('eth_accounts');
+
+  it('returns empty array', async () => {
+    const res = await eth_accounts([]);
+    expect(res.status).to.equal(200);
+    expect(res.data.result).to.deep.equal([]);
+  });
+});
diff --git a/eth-rpc-adapter/src/eip1193-bridge.ts b/eth-rpc-adapter/src/eip1193-bridge.ts
@@ -156,9 +156,10 @@ class Eip1193BridgeImpl {
     return hexValue(gasPrice);
   }
 
-  // async eth_accounts(params: any[]): Promise<any> {
-
-  // }
+  async eth_accounts(params: any[]): Promise<any> {
+    validate([], params);
+    return [];
+  }
 
   /**
    * Returns the value from a storage position at a given address.