Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize rpc response for contract revert #756

Merged
merged 12 commits into from
Jun 25, 2023

Conversation

shunjizhan
Copy link
Collaborator

@shunjizhan shunjizhan commented Jun 21, 2023

Change

  • standardized rpc response when there is revert data, now hardhat matchers works out of box. Revert msg should look like this for evm contract revert
{
      code: -32603,
      data?: '0x hex revert data',
      message?: 'human readable revert data',
    }
  • removed old mandala endpoint usage
  • removed unused file

Test

removed matcher override from hardhat tutorials, and it's compatible with current RPCs

AcalaNetwork/hardhat-tutorials#102

@shunjizhan shunjizhan changed the title standard revert response standardize rpc response for contract revert Jun 25, 2023
@shunjizhan shunjizhan marked this pull request as ready for review June 25, 2023 07:44
@shunjizhan shunjizhan requested review from xlc and zjb0807 June 25, 2023 07:44
@shunjizhan shunjizhan merged commit 5a2fc46 into master Jun 25, 2023
12 checks passed
@shunjizhan shunjizhan deleted the standard-revert-response branch June 25, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants