Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hrmp from unregistered parachains #635

Merged
merged 3 commits into from
Jan 31, 2024
Merged

hrmp from unregistered parachains #635

merged 3 commits into from
Jan 31, 2024

Conversation

ermalkaleci
Copy link
Collaborator

No description provided.

@ermalkaleci ermalkaleci linked an issue Jan 16, 2024 that may be closed by this pull request
@NachoPal
Copy link

It didn't work:

Getting this error:

[11:45:32.039] TRACE (txpool/46745): build block
    app: "chopsticks"
    params: {
      "transactions": [],
      "upwardMessages": {},
      "downwardMessages": [],
      "horizontalMessages": {
        "2000": [
          {
            "sentAt": 6084721,
            "data": "0x000314000400000204320503d2029649000700e87648171300000204320503d2029649000700e876481700060103008c864782380100ac320103d202964900d43593c715fdd31c61141abd04a99fd6822c8558854ccde39a5684e7a56da27d01a10f140d010000010100d43593c715fdd31c61141abd04a99fd6822c8558854ccde39a5684e7a56da27d"
          }
        ]
      }
    }
file:///Users/nacho/Desktop/PARITY/Repos/chopsticks/packages/core/src/blockchain/inherent/parachain/validation-data.ts:119
        const hrmpMessages = _.mergeWith(extrinsic.horizontalMessages, params.horizontalMessages, (objValue, srcValue)=>objValue.concat(srcValue));
                                                                                                                                 ^

TypeError: Cannot read properties of undefined (reading 'concat')
    at file:///Users/nacho/Desktop/PARITY/Repos/chopsticks/packages/core/src/blockchain/inherent/parachain/validation-data.ts:119:130
    at baseMergeDeep (/Users/nacho/Desktop/PARITY/Repos/chopsticks/node_modules/lodash/lodash.js:3685:11)
    at /Users/nacho/Desktop/PARITY/Repos/chopsticks/node_modules/lodash/lodash.js:3645:11
    at /Users/nacho/Desktop/PARITY/Repos/chopsticks/node_modules/lodash/lodash.js:4967:15
    at baseMerge (/Users/nacho/Desktop/PARITY/Repos/chopsticks/node_modules/lodash/lodash.js:3642:7)
    at /Users/nacho/Desktop/PARITY/Repos/chopsticks/node_modules/lodash/lodash.js:13541:7
    at Function.<anonymous> (/Users/nacho/Desktop/PARITY/Repos/chopsticks/node_modules/lodash/lodash.js:4915:13)
    at apply (/Users/nacho/Desktop/PARITY/Repos/chopsticks/node_modules/lodash/lodash.js:489:27)
    at Function.mergeWith (/Users/nacho/Desktop/PARITY/Repos/chopsticks/node_modules/lodash/lodash.js:6627:16)
    at SetValidationData.createInherents (file:///Users/nacho/Desktop/PARITY/Repos/chopsticks/packages/core/src/blockchain/inherent/parachain/validation-data.ts:119:32)

@ermalkaleci
Copy link
Collaborator Author

@NachoPal I've pushed some changes. Now we inject arbitrary paraId into validation data

@ermalkaleci ermalkaleci merged commit 827c653 into master Jan 31, 2024
7 checks passed
@ermalkaleci ermalkaleci deleted the hrmp-any-parachain branch January 31, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HRMP not working for genesis mode after opening channels
2 participants