connectHorizontal open any channel #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NachoPal this should fix the channel opening |
xlc
reviewed
Mar 12, 2024
| @@ -30,5 +30,15 @@ export const connectHorizontal = async (parachains: Record<number, Blockchain>) | |||
| } | |||
| } | |||
| }) | |||
|
|
|||
| const hrmpHeads = await chain.head.read('BTreeMap<u32, H256>', meta.query.parachainSystem.lastHrmpMqcHeads) | |||
| if (hrmpHeads && !process.env.DISABLE_AUTO_HRMP) { | |||
There was a problem hiding this comment.
best to avoid env in the core package. they are global variables so all the reason to avoid global variables applies.
we should just pass arguments into here, and should be the cli package to handle envs. also need to document them
There was a problem hiding this comment.
Yes we have a few places when we use env, we need to address them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.