Tanssi: Add support for expectedBlockTime of async backing pallet
#694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
At Tanssi, we are working on adding support for asynchronous backing. Of course, this involves changing the slot duration from
12000milliseconds to6000milliseconds.While trying to test some features using chopsticks (like upgrading the on-chain runtime), we are encountering the issue that the network doesn't even start. The reason for this is that at the moment of fetching the slot duration inside
getSlotDurationfunction, Tanssi chain metadata doesn't match with any of the current statements.As Tanssi doesn't make use of Aura or Babe pallets directly, but instead of the AsyncBacking pallet (implemented in Moonkit repo), it would be nice to have an extra statement that checks for the existence of this pallet and thus retrieve the correct slot duration from there.