Merge pull request #29 from rexydwybrundy/no-jira-decrease-sleep-and-…

…use-predefine-topic feat: decrease the sleep time and use predefine topic for the test
AccelByte · Sep 23, 2021 · e43c717 · e43c717
2 parents e32f05a + 0a8022d
commit e43c717
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 2 deletions.
diff --git a/Makefile b/Makefile
@@ -17,7 +17,7 @@ clean:
 
 test:
 	docker-compose -f docker-compose-test.yml up -d -V
-	sleep 50
+	sleep 30
 	go test -v ./...
 	docker-compose -f docker-compose-test.yml down
 

diff --git a/docker-compose-test.yml b/docker-compose-test.yml
@@ -37,6 +37,7 @@ services:
       - KAFKA_ADVERTISED_PORT=9092
       - KAFKA_ADVERTISED_HOST_NAME=localhost
       - KAFKA_ZOOKEEPER_CONNECT=zookeeper:2181
+      - KAFKA_CREATE_TOPICS=prefix.testTopic:1:1
     networks:
       - resource-network
 

diff --git a/docker-compose.yml b/docker-compose.yml
@@ -37,6 +37,7 @@ services:
       - KAFKA_ADVERTISED_PORT=9092
       - KAFKA_ADVERTISED_HOST_NAME=kafka
       - KAFKA_ZOOKEEPER_CONNECT=zookeeper:2181
+      - KAFKA_CREATE_TOPICS=prefix.testTopic:1:1
     networks:
       - resource-network
 

diff --git a/kafka_integration_multiple_subscribers_ack_test.go b/kafka_integration_multiple_subscribers_ack_test.go
@@ -39,7 +39,7 @@ func TestMultipleSubscriptionsEventuallyProcessAllEvents(t *testing.T) {
 
 	client := createKafkaClient(t)
 
-	topicName := constructTopicTest()
+	topicName := preCreateTopic
 
 	var mockPayload = make(map[string]interface{})
 	mockPayload[testPayload] = "testPayload" // nolint:goconst

diff --git a/kafka_integration_test.go b/kafka_integration_test.go
@@ -36,6 +36,7 @@ const (
 	errorTimeout   = "timeout while executing test"
 	errorPublish   = "error when publish event"
 	errorSubscribe = "error when subscribe event"
+	preCreateTopic = "testTopic"
 )
 
 type Payload struct {