messagebus initial implementation #1
Conversation
|
Write README documenting the library's usage please |
|
Sure, because we have another priority |
kafka.go
Outdated
|
|
||
| // SetTimeout set listening timeout for publish with response | ||
| func (client *KafkaClient) SetTimeout(timeout int) { | ||
| if timeout < 10000 { |
There was a problem hiding this comment.
don't you think it's better to put this into a const?
There was a problem hiding this comment.
sure, I will update it
thanks
| topicDetails := make(map[string]*sarama.TopicDetail) | ||
| topicDetails[topicName] = topicDetail | ||
| request := sarama.CreateTopicsRequest{ | ||
| Timeout: time.Second * 15, |
There was a problem hiding this comment.
also this one, better to put in a constant
There was a problem hiding this comment.
sure, will update it
Thanks
kafka.go
Outdated
| // deleteTopic delete kafka topic | ||
| func deleteTopic(broker *sarama.Broker, topicName string) error { | ||
| request := sarama.DeleteTopicsRequest{ | ||
| Timeout: time.Second * 15, |
There was a problem hiding this comment.
also this one, better to put in a constant
There was a problem hiding this comment.
sure, I will update it
thanks
| receivedMessage := unmarshal(consumerMessage) | ||
|
|
||
| // check the request and response message ID should be equal | ||
| if messageID != receivedMessage.MessageId { |
There was a problem hiding this comment.
is it possible that the receivedMessage is nil?
There was a problem hiding this comment.
I think its not possible because if unmarshal function get an error, it will return empty struct
kafka.go
Outdated
|
|
||
| // currently only support 1 message broker | ||
| broker := sarama.NewBroker(brokerList[0]) | ||
| _ = broker.Open(config) |
There was a problem hiding this comment.
is this an error that you silent? or something else?
There was a problem hiding this comment.
you're right, I will update it
thanks
messagebus.go
Outdated
| package messagebus | ||
|
|
||
| const ( | ||
| GDPR_DeletionAccount string = "GDPR:deletionAccount" |
There was a problem hiding this comment.
this is a topic name, we registered the topic name as a public constant so the client doesn't need to manually set the topic
fadhillahentino
force-pushed
the
messagebus-initial-implementation
branch
from
79ec6d2
to
2ab7e53
Compare
Features added :
please help me to review @thoriqsatriya @banukusuma @rjjatson @desniaak @purbopanambang @rafi-isakh