Conversion to umbrella project and other improvements #31

kevinbader · 2018-01-21T19:38:32Z

No description provided.

For a reliable startup, sup_wrapper is needed after all..

…way & fixed dependencies

…gateway into umbrella

kevinbader · 2018-01-21T19:39:02Z

@mmacai with 1.1.0 out the door, it's time to get this merged into mainline and iterate from there

mmacai

mix docs outputs:

warning: function UUID.uuid4/0 is undefined (module UUID is not available)
  lib/rig_inbound_gateway/request_logger/kafka.ex:34

same message produced by running mix phx.server

docker build ... failed with:

** (File.Error) could not open "./guides/operator-guide.md": no such file or directory
    (elixir) lib/file.ex:1183: File.open!/2

mmacai · 2018-01-22T08:41:58Z

apps/rig_api/README.md

@@ -0,0 +1,20 @@
+# RigApi


Do we want to keep this file? or maybe better question do we want to have README.md files for each umbrella app?

I'll keep the README files but only include a link to the developer's guide

mmacai · 2018-01-22T08:57:00Z

apps/rig_auth/README.md

+```elixir
+def deps do
+  [
+    {:rig_auth, "~> 0.1.0"}


Should be 2.0.0, probably.

I'd say we remove this altogether

mmacai · 2018-01-22T08:57:54Z

apps/rig_auth/test/blacklist_test.exs

+    tracker =
+      Stubr.stub!(
+        [
+          # @callback track(jti: String.t, expiry: Timex.DateTime.t) :: {:ok, String.t}


Can be removed? Same for commented callbacks below.

hm that's meant as documentation as to what the mock should provide. But it's not checked by the compiler, so perhaps should be removed, not sure

mmacai · 2018-01-22T08:59:54Z

apps/rig_inbound_gateway/config/dev.exs

+  watchers: []
+
+# Do not include metadata nor timestamps in development logs TODO why?
+#config :logger, :console, format: "[$level] $message\n"


mmacai · 2018-01-22T09:20:04Z

apps/rig_inbound_gateway/lib/rig_inbound_gateway_web/presence/channel.ex

@@ -77,6 +77,20 @@ defmodule RigWeb.Presence.Channel do
    end
  end

+  @doc """
+  Sends off outgoing messages.


Didn't know about this one.

I still think it's rather strange

mmacai · 2018-01-22T09:32:16Z

apps/rig_outbound_gateway/README.md

+
+Work in progress:
+
+- HTTP API


Isn't this implemented or is the message API endpoint something different?

removed that

mmacai · 2018-01-22T09:41:26Z

apps/rig_outbound_gateway/mix.exs

+      {:brod, "~> 3.3"},
+      # JSON parser:
+      {:poison, "~> 2.0 or ~> 3.0"},
+      # HTTP server:


Remove deps?

mmacai · 2018-01-22T09:50:28Z

config/config.exs

+  :topic,
+  :partition,
+  :offset,
+  # aws_sqs_metadata


I guess this shouldn't be here yet.

mmacai · 2018-01-22T09:51:01Z

config/dev.exs

-  watchers: []
-
-# Do not include metadata nor timestamps in development logs TODO why?
+# Do not include metadata nor timestamps in development logs
 #config :logger, :console, format: "[$level] $message\n"


mmacai · 2018-01-22T09:56:00Z

version

@@ -0,0 +1,4 @@
+%{
+  rig: "2.0.0-dev",
+  elixir: "~> 1.5",


We should be able finally use 1.6. Same goes for Dockerfile.

mmacai · 2018-01-22T12:49:03Z

Missing COPY apps/rig_auth/config /opt/sites/rig/apps/rig_auth/config => leads to error during docker build ...
Since RUN mix release.init step was removed from Dockerfile, it should be removed from .gitignore and run manually MIX_ENV=prod mix release.init
even the fixes above, still getting error at the end of docker build ...

==> Assembling release..
==> Building release reactive_interaction_gateway:0.1.0 using environment prod
==> Including ERTS 9.2 from /usr/local/lib/erlang/erts-9.2
==> Packaging release..
==> Release packaging failed due to errors:
    Cannot add file sys.config to tar file - [{error,{25,erl_parse,["syntax error before: ",["Fun"]]}}]

mmacai · 2018-01-23T08:43:00Z

Tested with channels example and with some minor changes in example worked for both ws and sse.

kevinbader and others added 25 commits December 14, 2017 23:15

Convert to umbrella projects (and fix a few things alongs the way)

06b51a7

Rename :rig_common to :rig; enable metadata for log messages

d9e2f08

restructured rig_api, rig_auth and rig_inbound_gateway apps

cded870

fixed running of API services

e98370d

Merge branch 'master' into umbrella

52aa70e

Start a dedicated developer guide

f2b5d32

Use the same RIG and Elixir versions for all apps

839f0d1

Update Dockerfile to work with the umbrella setup

8ad097d

Work on the developer guide

16f7514

Move Blacklist to rig_auth

2ef6231

Add tests for rig_api's POST /messages + fix error handling

5c8da7f

Fix running mix tasks in subprojects by reading version file directly

15e5209

Restore Kafka impl

18f3f2a

For a reliable startup, sup_wrapper is needed after all..

Set Kafka to disabled by default

59e54be

removed jwt scope logic

d0ee687

Merge branch 'umbrella' into umbrella-local

0371c20

removed unused code from tests => rig_api, rig_auth, rig_inbound_gate…

5d9a00b

…way & fixed dependencies

Start operator's guide and add mix task to ensure defaults are current

af61470

Clean config files

7ff9dea

Merge branch 'umbrella' of github.com:Accenture/reactive-interaction-…

0efbb8f

…gateway into umbrella

Fix operator's guide path for update_docs mix task

f9c5bd1

Merge :rig_mesh into :rig

5d6f951

Support request logging (Kafka support is back)

4ace7af

Update changelog about request logging

ffa194e

Set logger level from info to warn for prod

42eb028

kevinbader added this to the 2.0.0 milestone Jan 21, 2018

kevinbader requested a review from mmacai January 21, 2018 19:38

kevinbader added 2 commits January 21, 2018 20:42

Fix credo warnings

1bc5d8b

Refactor update_docs

7f506d3

Allow missing default values for update_docs

092ac6d

mmacai requested changes Jan 22, 2018

View reviewed changes

kevinbader added 4 commits January 22, 2018 12:34

Clean up (review comments)

712d4a4

Set update_docs to only run when compiling the umbrella in DEV

7bdc11c

Set Elixir version from 1.5 to 1.6

cec40c0

Add missing UUID dependency to inbound-gw

3e36e07

Add Distillery release config and fix Docker build

16897f1

mmacai approved these changes Jan 23, 2018

View reviewed changes

kevinbader merged commit ea8a342 into master Jan 23, 2018

kevinbader deleted the umbrella branch January 23, 2018 09:02

This was referenced Jan 23, 2018

Convert the code base to an umbrella project #24

Closed

Run the internal API on a dedicated port #23

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Conversion to umbrella project and other improvements #31

Conversion to umbrella project and other improvements #31

kevinbader commented Jan 21, 2018

kevinbader commented Jan 21, 2018

mmacai left a comment

mmacai Jan 22, 2018

kevinbader Jan 22, 2018

mmacai Jan 22, 2018

kevinbader Jan 22, 2018

mmacai Jan 22, 2018

kevinbader Jan 22, 2018

mmacai Jan 22, 2018

kevinbader Jan 22, 2018

mmacai Jan 22, 2018

kevinbader Jan 22, 2018

mmacai Jan 22, 2018

kevinbader Jan 22, 2018

mmacai Jan 22, 2018

kevinbader Jan 22, 2018

mmacai Jan 22, 2018

kevinbader Jan 22, 2018

mmacai Jan 22, 2018

kevinbader Jan 22, 2018

mmacai Jan 22, 2018

kevinbader Jan 22, 2018

mmacai commented Jan 22, 2018

mmacai commented Jan 23, 2018

Conversion to umbrella project and other improvements #31

Conversion to umbrella project and other improvements #31

Conversation

kevinbader commented Jan 21, 2018

kevinbader commented Jan 21, 2018

mmacai left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mmacai commented Jan 22, 2018

mmacai commented Jan 23, 2018