Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

299 bug not getting progressstatus on functions #305

Merged
merged 17 commits into from
Dec 5, 2022
Merged

299 bug not getting progressstatus on functions #305

merged 17 commits into from
Dec 5, 2022

Conversation

DannyCastroVentura
Copy link
Contributor

PR details

What is the purpose of this pull request? (put an "X" next to an item)

  • Bug fix
  • Before, we were not able to get the loading spinner updated with the refresh's progress status at the retrieve function, this PR fixes that bug.

What changes did you make? (Give an overview)

  • Created a new apex method to get the progress status of a specific result
  • In the LWC used the event that was already there to know when to refresh the table, and added a new subscription to the MC_RESULT event to get the progress status of a specified job execution (using the new apex method)
  • Fixed the unsubscribed bug (before we were getting an error in the developer console every time that the script tried to unsubscribe because it needed 2 parameters, and we were providing only one.

Unsubscribe documentation:
https://developer.salesforce.com/docs/component-library/bundle/lightning-emp-api/documentation

Daniel Ventura added 11 commits November 24, 2022 15:52
#299 creating new apex method to return the current status, and start…
a402218 
… changing mcdo_retrieveTable in order to handle the new method
#299 adding the other functions, but still with the window.setTimeout…
857e7fa 
… error
#299 changed the from this.status to this.progressStatus
7dccdac
#299 change the mcdo_RunCopadoFunctionFromLWC.cls and mcdo_RetrieveTa…
638202b 
…ble.js to its previous state, once that this logic wont work, and will try to use the event's logic
#299 - added some console.logs
3b79faf
#299 - updated some console.logs
89cc167
#299 adding a method in order to get the job progress
eecf6c0
#299 using that method to retrieve the job progress on the message ca…
ed2284e 
…ll back
#299 changed the event that we are getting information about and chan…
b856c46 
…ge the logic as well so it can get the appropriate data, but it still have a bug, it is refreshing the table before the event actually ended
#299 changing logic to use both events, one to update the progress me…
7286b49 
…ssages, and the other to refresh the table once it the retrieve is done. New bug: sometimes the messages get confused with some other job steps (I think)
#299 fixing the bug, it wasn't unsubscribing, and so it was continuin…
4c774d0 
…g to get message from the older subscriptions as well
@DannyCastroVentura DannyCastroVentura self-assigned this Nov 30, 2022
@DannyCastroVentura DannyCastroVentura linked an issue Nov 30, 2022 that may be closed by this pull request
[BUG] Not getting progressStatus on functions #299
Closed
JoernBerkefeld and others added 4 commits December 5, 2022 09:58
@JoernBerkefeld
#299: prototype of getResultIds
134ae1c 
still buggy; jobProgressWrapper & getJobProgress will be irrelevant when this works
#299 updating logic so we don't need to retrieve all the progress sta…
a80e128 
…tus from database but just the latest result id, and use the events to get it basing itself on the retrieved resultId
#299 changing logic so it gets all the result ids from the jobExcepti…
bf46ae6 
…onId
@JoernBerkefeld
#299: reduce result id response by filtering "closed" ones
290bce3
@JoernBerkefeld
Copy link
Collaborator

confirmed working :)

@JoernBerkefeld
Copy link
Collaborator

JoernBerkefeld commented Dec 5, 2022 •
edited
Loading

events as seen on the org based on our latest solution:

image

during the same time these events were published (applied different filter on console)
image

note:
event test conducted while no other results were running --> overlap not logged here

@JoernBerkefeld JoernBerkefeld merged commit 159e288 into master Dec 5, 2022
@JoernBerkefeld JoernBerkefeld deleted the 299-bug-not-getting-progressstatus-on-functions branch December 5, 2022 14:32
@JoernBerkefeld JoernBerkefeld added this to the 1.3.0 milestone Dec 5, 2022
This was linked to issues Dec 5, 2022
[FEATURE] filter event messages by result id / job step id #200
Closed
[BUG] no progress messages during retrieve since copado deployer v20 #287
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoernBerkefeld JoernBerkefeld JoernBerkefeld approved these changes

Assignees

@DannyCastroVentura DannyCastroVentura

Labels
None yet
Projects
None yet
Milestone
1.3.0
2 participants
@DannyCastroVentura @JoernBerkefeld