Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] improve folder caching #1470

Closed
JoernBerkefeld opened this issue Jul 22, 2024 · 1 comment · Fixed by #1480 or #1428
Closed

[TASK] improve folder caching #1470

JoernBerkefeld opened this issue Jul 22, 2024 · 1 comment · Fixed by #1480 or #1428
Assignees
@JoernBerkefeld
Labels
c/folder COMPONENT chore Jira issue-type "Task"
Milestone
7.1.0

Comments

@JoernBerkefeld
Copy link
Contributor

right now we always do 2 requests, one with QueryAllAccounts and one without - regardless of the folder types we request. that's likely more than we need. Also, it means we get a lot of folders back that belong to the parent BU without that helping us at all.
@JoernBerkefeld JoernBerkefeld added c/folder COMPONENT chore Jira issue-type "Task" labels Jul 22, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.1.0 milestone Jul 22, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Jul 22, 2024
JoernBerkefeld added a commit that referenced this issue Jul 22, 2024
@JoernBerkefeld
#1470: TESTING: include QueryAllAcounts in soap response paths
70f2bfa
JoernBerkefeld added a commit that referenced this issue Jul 22, 2024
@JoernBerkefeld
#1470: add folder type "asset" to types that can be shared from the p…
a445f46 
…arent
@JoernBerkefeld JoernBerkefeld mentioned this issue Jul 22, 2024
Merged
4 tasks
JoernBerkefeld added a commit that referenced this issue Jul 22, 2024
@JoernBerkefeld
#1470: improve folder loading - part 2
f5a0f22
JoernBerkefeld added a commit that referenced this issue Jul 22, 2024
@JoernBerkefeld
#1470: sort folder subtypes alphabetically in requests to ease testing
7225a8e
@JoernBerkefeld JoernBerkefeld linked a pull request Jul 22, 2024 that will close this issue
Task/1470 improve folder caching #1480
Merged
4 tasks
@github-actions GitHub Actions
Copy link

Closed by #1480.

@JoernBerkefeld JoernBerkefeld mentioned this issue Jul 23, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
c/folder COMPONENT chore Jira issue-type "Task"
Projects
None yet
Milestone
7.1.0
Development

Successfully merging a pull request may close this issue.

Task/1470 improve folder caching Accenture/sfmc-devtools
release 7.1.0 Accenture/sfmc-devtools
1 participant
@JoernBerkefeld