Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] buildDefinition does not rename single extracted code files #1473

Closed
2 tasks done
JoernBerkefeld opened this issue Jul 22, 2024 · 1 comment · Fixed by #1486 or #1428
Closed
2 tasks done

[BUG] buildDefinition does not rename single extracted code files #1473

JoernBerkefeld opened this issue Jul 22, 2024 · 1 comment · Fixed by #1486 or #1428
Assignees
@JoernBerkefeld
Labels
bug Something isn't working c/asset COMPONENT PRIORITY used for professional service clients
Milestone
7.1.0

Comments

@JoernBerkefeld
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

image

Expected Behavior

it should have renamed all html files to end on "_SIT" in this scenario based on the supplied market - similar to what it did to the jsons.

Steps To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Run '...'
  4. See error...

Version

7.0.4

Environment

  • OS:
  • Node:
  • npm:

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@JoernBerkefeld JoernBerkefeld added bug Something isn't working c/asset COMPONENT labels Jul 22, 2024
@JoernBerkefeld JoernBerkefeld added this to the 7.1.0 milestone Jul 22, 2024
@JoernBerkefeld JoernBerkefeld self-assigned this Jul 22, 2024
@JoernBerkefeld JoernBerkefeld added the PRIORITY used for professional service clients label Jul 22, 2024
JoernBerkefeld added a commit that referenced this issue Jul 22, 2024
@JoernBerkefeld
#1473: rename test asset to prep for simple asset buildDefinition test
b0295b8
JoernBerkefeld added a commit that referenced this issue Jul 22, 2024
@JoernBerkefeld
#1473: fix buildDefinition for simple asset types
cfe2ef3
JoernBerkefeld added a commit that referenced this issue Jul 22, 2024
@JoernBerkefeld
#1473: tests for simple assets with one extracted code block
01e7e7f
@JoernBerkefeld JoernBerkefeld mentioned this issue Jul 22, 2024
Merged
4 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Jul 22, 2024 that will close this issue
Bug/1473 builddefinition does not rename single extracted code files #1486
Merged
4 tasks
@github-actions GitHub Actions
Copy link

Closed by #1486.

@JoernBerkefeld JoernBerkefeld mentioned this issue Jul 23, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/asset COMPONENT PRIORITY used for professional service clients
Projects
None yet
Milestone
7.1.0
1 participant
@JoernBerkefeld