Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] createDeltaPkg does not list all changes between 2 commits #688

Closed
2 tasks done
JoernBerkefeld opened this issue Jan 31, 2023 · 2 comments · Fixed by #715
Closed
2 tasks done

[BUG] createDeltaPkg does not list all changes between 2 commits #688

JoernBerkefeld opened this issue Jan 31, 2023 · 2 comments · Fixed by #715
Assignees
@JoernBerkefeld
Labels
bug Something isn't working e/DevOps EPIC PRIORITY used for professional service clients
Milestone
4.3.2

Comments

@JoernBerkefeld
Copy link
Contributor

JoernBerkefeld commented Jan 31, 2023 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

it seems like its only getting changes from the last commit.

Expected Behavior

full list of changes in between 2 commits is returned

Steps To Reproduce

test with 7f31e26..a57dade

Version

4.3.0

Participation

  • I am willing to submit a pull request for this issue.
@JoernBerkefeld JoernBerkefeld added bug Something isn't working e/DevOps EPIC PRIORITY used for professional service clients labels Jan 31, 2023
@JoernBerkefeld JoernBerkefeld added this to the 4.3.1 milestone Jan 31, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Jan 31, 2023
@JoernBerkefeld JoernBerkefeld modified the milestones: 4.3.1, 4.3.2 Feb 2, 2023
JoernBerkefeld added a commit that referenced this issue Feb 7, 2023
@JoernBerkefeld
#688: fix createDeltaPkg not finding changes
cd8d9fb
JoernBerkefeld added a commit that referenced this issue Feb 7, 2023
@JoernBerkefeld
#688: filter files that are irrelevant for deployment (error.log + md)
8e800e8
@JoernBerkefeld JoernBerkefeld mentioned this issue Feb 7, 2023
Merged
2 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Feb 7, 2023 that will close this issue
Bugfix/688 createDeltaPkg does not list all changes between 2 commits #715
Merged
2 tasks
@JoernBerkefeld JoernBerkefeld changed the title [BUG] createDeltaPkg does not use actual comparison between 2 commits [BUG] createDeltaPkg does not list all changes between 2 commits Feb 7, 2023
@JoernBerkefeld
Copy link
Contributor Author

turns out that the path filter malfunctioned due to a missing path.normalize() call

@github-actions github-actions bot closed this as completed Feb 7, 2023
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

Closed by #715.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working e/DevOps EPIC PRIORITY used for professional service clients
Projects
None yet
Milestone
4.3.2
1 participant
@JoernBerkefeld