Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] update event broken because logic still uses FuelSDK parameters #871

Closed
2 tasks done
JoernBerkefeld opened this issue Apr 22, 2023 · 1 comment · Fixed by #872
Closed
2 tasks done

[BUG] update event broken because logic still uses FuelSDK parameters #871

JoernBerkefeld opened this issue Apr 22, 2023 · 1 comment · Fixed by #872
Assignees
@JoernBerkefeld
Labels
bug Something isn't working c/event COMPONENT
Milestone
5.0.0

Comments

@JoernBerkefeld
Copy link
Contributor

JoernBerkefeld commented Apr 22, 2023 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

simply broken because of outdated params

Expected Behavior

can be easily rewritten to use super.updateREST(metadataEntry, uri, 'put')

Version

4.3.4

Participation

  • I am willing to submit a pull request for this issue.
@JoernBerkefeld JoernBerkefeld added bug Something isn't working c/event COMPONENT labels Apr 22, 2023
@JoernBerkefeld JoernBerkefeld added this to the 5.0.0 milestone Apr 22, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this Apr 22, 2023
JoernBerkefeld added a commit that referenced this issue Apr 22, 2023
@JoernBerkefeld
#871: fix update-event
867f143 
now uses generic method instead of outdated fuelSDK custom logic
@JoernBerkefeld JoernBerkefeld mentioned this issue Apr 22, 2023
Merged
2 tasks
@JoernBerkefeld JoernBerkefeld linked a pull request Apr 22, 2023 that will close this issue
#871: fix update for type event #872
Merged
2 tasks
JoernBerkefeld added a commit that referenced this issue Apr 24, 2023
@JoernBerkefeld
Merge pull request #872 from Accenture/bugfix/871-update-event-broken…
eb1eed7 
…-because-logic-still-uses-fuelsdk-parameters

#871: fix update for type `event`
@github-actions
Copy link

Closed by #872.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/event COMPONENT
Projects
None yet
Milestone
5.0.0
1 participant
@JoernBerkefeld