Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] dataExtensionField rename shows bad info message #923

Closed
2 tasks done
JoernBerkefeld opened this issue May 23, 2023 · 1 comment · Fixed by #929
Closed
2 tasks done

[BUG] dataExtensionField rename shows bad info message #923

JoernBerkefeld opened this issue May 23, 2023 · 1 comment · Fixed by #929
Assignees
@JoernBerkefeld
Labels
bug Something isn't working c/dataExtension COMPONENT
Milestone
5.0.2

Comments

@JoernBerkefeld
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

when trying to rename a field, while that actually works, we get a WARN message that includes an undefined:

image

Expected Behavior

  • it should be an INFO message instead because there is nothing bad happening
  • the undefined should instead be the new field name
  • the old field name should also be included

Steps To Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Run '...'
  4. See error...

Version

5.0.1

Environment

  • OS:
  • Node:
  • npm:

Participation

  • I am willing to submit a pull request for this issue.

Additional comments

No response
@JoernBerkefeld JoernBerkefeld added bug Something isn't working c/dataExtension COMPONENT labels May 23, 2023
@JoernBerkefeld JoernBerkefeld added this to the 5.0.2 milestone May 23, 2023
@JoernBerkefeld JoernBerkefeld self-assigned this May 23, 2023
JoernBerkefeld added a commit that referenced this issue May 24, 2023
@JoernBerkefeld
#923: corrected dataExtensionField rename log message
bc33a05
@JoernBerkefeld JoernBerkefeld mentioned this issue May 24, 2023
Merged
1 task
JoernBerkefeld added a commit that referenced this issue May 24, 2023
@JoernBerkefeld
#923: add empty test for renaming fields
61591a0
JoernBerkefeld added a commit that referenced this issue May 24, 2023
@JoernBerkefeld
Merge pull request #929 from Accenture/bugfix/923-dataextensionfield-…
f14f0f0 
…rename-shows-bad-info-message

bugfix/#923: corrected dataExtensionField rename log message
@JoernBerkefeld JoernBerkefeld linked a pull request May 24, 2023 that will close this issue
bugfix/#923: corrected dataExtensionField rename log message #929
Merged
1 task
@github-actions
Copy link

Closed by #929.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoernBerkefeld JoernBerkefeld

Labels
bug Something isn't working c/dataExtension COMPONENT
Projects
None yet
Milestone
5.0.2
1 participant
@JoernBerkefeld