Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADG-308 Table spanning multiple rows and columns #430

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

backflip
Copy link
Collaborator

@backflip backflip commented Mar 5, 2024

Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for accessibility-developer-guide ready!

Name Link
🔨 Latest commit b70cccc
🔍 Latest deploy log https://app.netlify.com/sites/accessibility-developer-guide/deploys/65e794aa8b8fe100091b131b
😎 Deploy Preview https://deploy-preview-430--accessibility-developer-guide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@christophdubach
Copy link
Collaborator

christophdubach commented Apr 2, 2024

@backflip: To me the source code additions look good and cover Adrian's feedback.

(But what I was wondering: Should the <th>s of the individual rows (those with the time specification) also have an id, and should this id also be listed in the headers attribute of the <td>s? Or does this only apply to header cells of columns?)

Important note:
I cannot judge the correctness of the text section “Tricky screen reader navigation” or the compatibility table – my approval therefore only applies to the code ... 😉

@NicSR
Copy link
Contributor

NicSR commented May 30, 2024

Sali Zäme

Nun ich habe jetzt mehrere Tests gemacht mit den Beispielen die wir anbieten und dem Beispiel von Adrian.
In unseren Beispielen passiert gar nichts, und das Verhalten in Chrom/Firefox mit NVDA ist identisch. Es werden jeweils die Headers ausgelesen im thead-element drin unabhängig davon ob mit oder ohne ID.

Nun anders sieht es aus beim Beispiel von Adrian: https://adrianroselli.com/2022/01/accessible-cart-tables.html
image
da wird versucht, der Zelle "sub-total" die Header-Bezeichnung "Description" zu setzten.
dies allerdings funktioniert nur in Firefox und NVDA nicht aber in Chrome und NVDA.

wollen wir dies als Beispiel mit im ADG aufnehmen um die Problematik stand heute zu zeigen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants