refactor!: Rename the static text role to label #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The term "static text" is archaic; it goes back to the early days of Windows and, if I remember correctly, the original Macintosh Toolbox. But every modern GUI toolkit I can think of, as far back as Java's AWT in the 90s, refers to this type of object as a label, whether or not it's actually labeling another control. To achieve our goal of making accessibility approachable to today's developers, we should eliminate unfamiliar and archaic terminology wherever we can. So, while this is another inconvenience for our early adopters, I think this name change is worthwhile.
Also, I now believe that the role that we used to call static text, that we now call label, should map to the AT-SPI label role, not the AT-SPI static role. This is based on what I see in both GTK 3 and 4, which use the label role whether or not the text actually has a label relationship with another widget.